Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I added a global option ('ssh-options') to override what backend invoke passes to ssh. Default behavior is the same as current behavior; set this to empty to allow password authentication.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | remove-ssh-options.patch | 3.66 KB | greg.1.anderson |
| #4 | ssh-options-2.patch | 1.52 KB | greg.1.anderson |
| ssh-options.patch | 2.35 KB | greg.1.anderson |
Comments
Comment #1
moshe weitzman commentedOK with me. Lets give Adrian a couple days to comment.
Comment #2
moshe weitzman commentedMy only hesitation is with clutterring the global options with this rarely used entry. Maybe we just document it in example.drushrc.php and leave it at that?
Comment #3
greg.1.anderson commentedThat would be fine by me...
Comment #4
greg.1.anderson commentedSame patch as above, but without the change to the global help options.
Comment #5
moshe weitzman commentedCommitted.
Comment #6
dman commentedFYI cross-reference with #686384: Allow the site-aliases configs to define extra options when invoking ssh
Comment #7
greg.1.anderson commentedBased on a comment in #686384: Allow the site-aliases configs to define extra options when invoking ssh, I present this alternate proposal: take out ssh-options altogether, and add comments directing the users to .ssh/config.
@adrian: This removes your PasswordAuthentication=no from backend_invoke, so I'm assigning this to you for your review.
Comment #8
adrian commentedi added the password authentication because the command would hang with no feedback and require to be exited with kill to get back.
unless you can somehow ensure that ssh will never try to open a read from shell (which is a bit tricky since ssh uses a different term for the input for security reasons), i'm not sure we can commit this.
Comment #9
adrian commentedactually. looking at the code. it only seems to be defaulted.
if you want to break your system, you should be free to.
feel free to ommit
Comment #10
greg.1.anderson commented@adrian: Your comment refers to #4, which has already been committed. #7 removes password authentication altogether.
On my Debian/Ubuntu system, it works just fine with password authentication (although it's better with ssh key authentication, of course). Does it break on other systems, or does it break if backend invoke calls a function that calls backend invoke (remotely)?
Comment #11
moshe weitzman commented#7 is won't fix in favor of #686384: Allow the site-aliases configs to define extra options when invoking ssh. returning issue a resting state.