Closed (fixed)
Project:
Invite
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Dec 2009 at 20:54 UTC
Updated:
27 Nov 2011 at 23:45 UTC
Jump to comment: Most recent file
Any plans for porting this community essential module to Drupal 7?
| Comment | File | Size | Author |
|---|---|---|---|
| #71 | invite.admin_.patch | 1.44 KB | william.lai |
| #71 | invite.module.patch | 517 bytes | william.lai |
| #47 | invite.module.patch | 922 bytes | hgroover |
| #47 | invite.admin.inc.patch | 643 bytes | hgroover |
| #12 | invite_d7.patch | 68.71 KB | hadsie |
Comments
Comment #1
smk-ka commentedInitial port. Currently broken, since Tokens need to be updated for D7 (where's the docs for that?), therefore 'needs work'.
Comment #2
BenK commentedSubscribe...
Comment #3
BenK commentedI just came across a link to some documentation on how to update Token integration for Drupal 7. So I thought I would post it on this thread, too:
Token API changes for Drupal 7
http://drupal.org/handbook/modules/token/update/6/7
--Ben
Comment #4
BenK commentedAlso, here's a helpful video tutorial on updating Token for D7 from DrupalCon San Francisco:
http://sf2010.drupal.org/conference/sessions/token-fun-and-profit-drupal-7
Comment #5
BenK commentedI did a bit more research and because Token is now included in D7 core (with a lot of documentation in core, too), it's the perfect time to implement support for tokens.
There's really two separate issues here:
A. Allowing tokens from core (and contrib modules that supply tokens) to be used within an Invite.
B. Having Invite add its own tokens to be used by other modules.
Neither looks too difficult to implement, but perhaps we should start with A because it looks especially straightforward.
So I took a look at the token.inc file found in D7 core (includes/token.inc). It looks like the token_replace() function should do the trick. Here's the example it provides at the top of the file:
Note that D7 core doesn't provide a method to list available tokens for users. However, I found this documentation page (http://drupal.org/handbook/modules/token/update/6/7) that shows how to list available tokens using the D7 version of the Token contrib module (which fills in a few minor gaps in the core implementation):
The cool thing about the above code is that it displays a brand new "token browser" that is much nicer to look at than in D6.
So sma-ka, what do you think?
Cheers,
Ben
Comment #6
BenK commented@smk-ka: I tried to apply your patch in #1, but I wasn't able to apply it against HEAD. Can you re-roll against the current HEAD? I'd like to start active reviewing and reporting back bugs I find.
When I tried to apply the patch, here are the errors I got:
patching file invite.info
patching file invite.install
patching file invite.module
Hunk #3 FAILED at 57.
Hunk #4 FAILED at 119.
Hunk #5 succeeded at 145 (offset 1 line).
Hunk #6 succeeded at 236 (offset 1 line).
Hunk #7 succeeded at 322 (offset 5 lines).
Hunk #8 succeeded at 348 (offset 5 lines).
Hunk #9 succeeded at 404 (offset 5 lines).
Hunk #10 succeeded at 421 (offset 5 lines).
Hunk #11 succeeded at 458 (offset 5 lines).
Hunk #12 succeeded at 468 (offset 5 lines).
Hunk #13 succeeded at 525 (offset 5 lines).
Hunk #14 succeeded at 570 (offset 5 lines).
Hunk #15 succeeded at 587 (offset 5 lines).
Hunk #16 succeeded at 600 (offset 5 lines).
Hunk #17 succeeded at 644 (offset 5 lines).
Hunk #18 succeeded at 658 (offset 5 lines).
Hunk #19 succeeded at 711 (offset 5 lines).
Hunk #20 succeeded at 733 (offset 5 lines).
Hunk #21 succeeded at 790 (offset 5 lines).
Hunk #22 succeeded at 835 (offset 5 lines).
Hunk #23 succeeded at 939 (offset 4 lines).
Hunk #24 succeeded at 969 (offset 4 lines).
Hunk #25 succeeded at 983 (offset 4 lines).
Hunk #26 succeeded at 1096 (offset 4 lines).
Hunk #27 succeeded at 1190 (offset 4 lines).
Hunk #28 succeeded at 1230 (offset 4 lines).
Hunk #29 FAILED at 1267.
Hunk #30 FAILED at 1283.
Hunk #31 succeeded at 1308 (offset -2 lines).
Hunk #32 succeeded at 1328 (offset -2 lines).
Hunk #33 succeeded at 1377 (offset -2 lines).
Hunk #34 succeeded at 1402 (offset -2 lines).
4 out of 34 hunks FAILED -- saving rejects to file invite.module.rej
patching file invite_admin.inc
Hunk #1 succeeded at 67 (offset 10 lines).
Hunk #2 FAILED at 99.
Hunk #3 succeeded at 121 (offset 9 lines).
Hunk #4 succeeded at 193 (offset 13 lines).
Hunk #5 succeeded at 220 (offset 13 lines).
Hunk #6 succeeded at 268 (offset 13 lines).
Hunk #7 succeeded at 294 (offset 13 lines).
Hunk #8 succeeded at 302 (offset 13 lines).
Hunk #9 succeeded at 351 (offset 13 lines).
Hunk #10 succeeded at 368 (offset 13 lines).
Hunk #11 succeeded at 378 (offset 13 lines).
Hunk #12 succeeded at 390 (offset 13 lines).
Hunk #13 succeeded at 401 (offset 13 lines).
Hunk #14 succeeded at 415 (offset 13 lines).
1 out of 14 hunks FAILED -- saving rejects to file invite_admin.inc.rej
patching file invite_cancel_account.info
patching file invite_cancel_account.module
patching file invite_stats.info
patching file invite_stats.module
patching file invite_token.inc
Thanks,
Ben
Comment #7
will_in_wi commentedSubscribe
Comment #8
Geeky Lass commentedsubscribing
Comment #9
jeffl8n commentedsubscribing
Comment #10
hadsie commentedNot sure what the current status is, but it seems like it hasn't changed since the initial patch from @smk-ka. I need this for D7 so I'm currently updating the patch to work with the latest code from HEAD. Hopefully I'll post the updated patch later tonight or tomorrow.
Comment #11
dgastudio commentedsub
Comment #12
hadsie commentedOk, here's an initial patch for D7. I've rewritten the token code but for some reason it still isn't picking it up, so I must have made a mistake somewhere. (i think invite_token.inc needed to be renamed to invite.token.inc). There's a few minor areas where I didn't port the code yet, but just left a @TODO for those areas.
Also, a number of the queries still need to be ported over to the new db_update/db_insert/db_delete style of query.
This is more or less working for me now, so it may be worthwhile to create a D7 branch for it to continue work and bug fixes.
Comment #13
kinshuksunil commentedsubscribing
Comment #14
chriz001 commentedsubscribing
Comment #15
ccheu commentedsubscribing
Comment #16
mehtatejas commentedcan you please provide drupal 7 version of invite module.
Comment #17
kissinger commentedWhen we can download the version for D7?
Comment #18
idiotprayer commentedsubscribe
Comment #19
sw3b commentedsubscribe
Comment #20
gvc commentedsubscribing
Comment #21
smk-ka commentedNice work, @hadsie! DRUPAL-7--2 has been created and #12 has been committed. For the token include file to be automatically picked up it needed to be renamed to invite.tokens.inc. invite_admin.inc has been renamed accordingly and the additional modules have been moved into its own subdirectory. Therefore, remember to wipe the module directory first, if you had a previous version installed or when upgrading from D6, and remember to run update.php or flush caches. There's still something broken, especially concerning tokens (can't visit the settings page), but let's fix those in separate issues.
Comment #22
mehtatejas commented@smk-ka where can we find DRUPAL-7--2 ?
Comment #23
hadsie commentedawesome! thanks @smk-ka. will start dropping new issues in new tickets :)
Comment #24
ccheu commentedMehtatejas,
You can find it here:
http://drupal.org/node/1052170
Comment #26
nevergoneHello, i'm new co-maintainer.
My Drupal 7 Plans:
- Full rewrite: Better API, maybe pluggable system
- Entity-based module: Field attached to Invite
- Full Views backend
Comment #27
lesleyfernandes commentedSubscribing
Comment #28
off commentedcool, nevergone
Comment #29
jeffwidman commentedWould LOVE to see some of the Launchrock.com functionality in either this module or a sub-module.
Their widget basically is a referral engine where you signup, and the 2nd page says "thx. we're giving more bonuses (or earlier access to private beta) if you invite more friends. Here's your referral link (think affiliate code appended to URL). You can also tweet/Facebook this link."
they auto-generate the twitter/facebook link buttons and wrap them back with the custom parameters so the referals are tied back to the individual users.
Right now, I don't see any clean way to pull this off with Drupal 7, so we just used the Launchrock widget on our homepage, but I'd rather use Drupal modules so I can keep better track of the users down the road.
(see it in action: http://pagelever.com/)
Comment #30
hendrakieran commented+1
Comment #31
nevergonehttp://drupal.org/node/1124708#comment-4376174
Comment #32
yugongtian commented+1
Comment #33
starsinmypockets commentedIs there any functional development code available for this module? Or could somebody outline the upgrade path? I would possibly be interested in helping to work on this.
Comment #34
hypertext200What is the difference of #1124708: To the maintainers -- Can we get some D7 patches applied to code? and this?
Comment #35
likewhoa commentedSubscribe...
Comment #36
whyn0t commentedSubscribe...
Comment #37
Håvard commentedSubscribing
Comment #38
theullrich commentedsub
Comment #39
Carlos Miranda Levy commentedsubscribe
Comment #40
rogical commented+1
Comment #41
nevergonehttp://drupalcode.org/project/invite.git/shortlog/refs/heads/7.x-4.x
Comment #42
Hazeltree commentedsubscribe
Comment #43
Fidelix commentedSubscribing...
Comment #44
kolobok38 commented+1
Comment #45
halloffame commentedSubscribing...
Comment #46
sslider999 commentedsub
Comment #47
hgroover commentedThanks to those who have put so much work into this module. I'm new to contributing and still getting into module development, but found a couple of issues running the 7.2 version with Drupal 7.2. Patches are attached:
1. The default email template doesn't have the right substitution tag
2. The processing of the invite does not have the right function reference.
I'm still looking into why you can't have admin-only registration - from looking at the module sources it should work, but I get "Access denied" when trying to use a registration invite unless registration is open or set to admin approval.
A probably-unrelated problem is that although I'm using user_relationships_invite to specify relationships at invite time, they are not applied. I think it's in the user_relationships_invite sub-module...
-Henry
Comment #48
likewhoa commented@hgroover best to leave title as is so it's easier to find for others, also you just need to set status to 'needs review' then the community and or a maintainer can look at your patch for review and ultimately inclusion into the project. Thanks for patch!
Comment #49
Taxoman commentedSubscribing
Comment #50
hgroover commented@likewhoa Thanks for the feedback, I'll make sure to do that next time. I wasn't able to edit those parts of my comment but if I end up with a better resolution to problems I'm still investigating I can re-post with updated patches.
Previously I've done all my Drupal site mods via php content hackage, just starting with Drupal 7 and now trying to do everything properly via modules...
Comment #51
milorand commentedsubscribing
Comment #52
dddbbb commentedAny chance we can get this up as a dev version on D.O?
Comment #53
Andy B commentedI am getting the following errors when enabling the module in D7.x-dev:
• Deprecated function: Call-time pass-by-reference has been deprecated in drupal_load() (line 911 of C:\inetpub\sites\Drupal\includes\bootstrap.inc).
• Deprecated function: Call-time pass-by-reference has been deprecated in drupal_load() (line 911 of C:\inetpub\sites\Drupal\includes\bootstrap.inc).
Sometimes I get 2 of these and sometimes I get 4 of them. The modules page is where I always get 4.
Comment #54
medden commentedsubscribing
Comment #55
likewhoa commented@medden this is a 'port issue' not a bug report issue, therefore it should be set as task.
Comment #56
likewhoa commentedjust updating title for better tracking.
Comment #57
medden commentedSorry I did initially add a bug report, but then found it was a duplicate, so I just edited my post.
Forgot to change the category sorry.
Comment #58
gillarf commentedsubscribe
Comment #59
jamiegotluckies commentedI am literally waiting on the 7.x release of this module to launch my website! Subscribing x1,000,000!
Comment #60
pancrilio commentedsubscribe
Comment #61
crispinbailey commented+1
Comment #62
davycw commented+1
Comment #63
orendain commentedsubbing
Comment #64
funkju commented+1
Comment #65
medden commentedIs there anything we can do to help get a working version released?
Comment #66
andrenoronha commented+1
Comment #67
jg352 commentedsubscribe
Comment #68
mefisto75 commentedsub
Comment #69
frank.schram commentedsubscribe
Comment #70
frank.schram commentedAfter sending an invitation, the following error pops up:
Warning: unserialize() expects parameter 1 to be string, array given in invite_get_remaining_invites() (line 702 of .../sites/all/modules/invite/invite.module).
Notice: Undefined index: rtid in user_relationship_invites_invite_form_validate() (line 52 of .../sites/all/modules/user_relationships/user_relationship_invites/user_relationship_invites.module).
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'rtid' cannot be null: INSERT INTO {user_relationship_invites} (inviter_uid, rtid, invite_code) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_0] => 23 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => x4ZfrZBy ) in user_relationship_invites_invite() (line 67 of .../sites/all/modules/user_relationships/user_relationship_invites/user_relationship_invites.module).
The invitation is sent succesfully, but after the invited user registers, he gets the following:
Fatal error: Call to undefined function invite_process() in .../sites/all/modules/invite/invite.module on line 481
Is this known??
Comment #71
william.lai commentedHi, i have two issue in invite.admin.inc and invite.module.
- cannot withdraw the invitation in user profile page
- cannot list details of invitation in admin page
Here are the patchs for it and please review.
Thanks,
Comment #72
william.lai commentedoh, updated the invite.module.patch with following code, otherwise, user with invitation code cannot process the registration in my case.
please review.
Comment #73
hubScrappy commentedRe: Comment #70
Just so that you don't think you are the only one afflicted, I get this one as well .. so it isn't somethign specific to your install ...
But ... if you disabled the User RElationships - Invite module, the error goes away ...
Comment #74
Refineo commentedsubscribe
Comment #75
ehmprah commented+1
Comment #76
frank.schram commentedRe: Comment #72
thank you, this works now
Comment #77
dgastudio commentedlast commits:
2 months ago 7.x-4.x
4 months ago 7.x-2.x
is this module still in development by mantainers?
Comment #78
rogical commentedhope some one can take over the 7.x-4.x development.
as invite is really important in social network building.
Comment #79
dannyjohnson1 commentedI would be willing to discuss a small amount of sponsorship - say $200 or £120 - for a fully tested release of a Drupal 7 version of Invite... if current or potential maintainers would like to get in touch. daniel [at] ashworthmarketing.co.uk
Comment #80
chris_boudreaux commentedI'll add another $100: chris [at] socialmediagovernance.com
Comment #81
mototribe commentedsubscribe
Comment #82
paul_constantine commentedsubscribe
Comment #83
hubScrappy commentedRight now, I don't much care about a 7.x-4.x version ... the concept is nice and all, but there is a mostly working 7.x-2.x version that is out there ... what would be nice is while the maintainers are playing with the 4.x version, they were to apply the various patches (I just posted a new one) that have been submitted for the 7.x-2.x branch, and package up a new 7.x-2.x-dev release, just so that those needing invite had a working version now ...
Real OSS developers don't get paid to develop, so it is understandable that the 7.x-4.x re-write is taking awhile while you keep a roof over your head and feed your children, but roll in patches that are submited for the older version ...
Comment #84
jg352 commentedwhere is 7.2 version?
Comment #85
dgastudio commentedjg352
http://drupal.org/node/20967/release?api_version%5B%5D=103
Comment #86
jg352 commentedthx kervi
Comment #87
jenlamptonsubscribe
Comment #88
scripthead commentedsubscribing
Comment #89
nagiek commented.
Comment #90
josephpnc commentedHi guys. It's so cool to know you guys are working to move this to Drupal 7. I got one issue though. After installing on Drupal 7.6, I can't find the option for: "New user registration by invitation only" under Configuration > Account Settings. Can somebody help? THANKS!
Btw, I downloaded it from here: http://drupal.org/node/20967/release?api_version[]=103 (version downloaded is invite 7.x-2.x-dev
Comment #91
Taxoman commented@josephpnc: please dont hijack this issue, open a new one for your support request. (by clicking on "create new issue" at the top of the issue queue page: http://drupal.org/project/issues/invite )
Comment #92
josephpnc commentedoh so sorry. will do.
Comment #93
sw3b commentedIs it possible to update the DEV with latest patch if possible... there is like a lot of thread with different patchs and DEV version is from april...
thanks !
Comment #94
mgiffordAgreed with @sw3b. Would be great to have a dev release.
Comment #95
glekli commentedI put the dev release on the project page so that it is more apparent that there is some progress going on in the 7.x branch.
The dev was recently updated with the patches that were in the issue queue and other refinements.
Comment #96
mgiffordThanks!
Comment #97
sw3b commentedthanks !
Comment #98
nagiek commentedThanks!
What's the -dev status? I'm sure it's not production ready, but beta-level? alpha-level? ..unstable? :)
Comment #99
glekli commentedI'd say it's a good alpha. Any bug reports are encouraged and welcome.
Comment #100
Taxoman commentedGreat! :-)
Comment #102
junkerjp commented"Re: Comment #70
Just so that you don't think you are the only one afflicted, I get this one as well .. so it isn't somethign specific to your install ...
But ... if you disabled the User RElationships - Invite module, the error goes away ..."
I was having the same issue. However, once a relationship type is actually created, that error will disappear.
Comment #103
glekli commentedjunkerjp,
That issue is related to UR module's Invite integration. See here http://drupal.org/node/1345694. The patch posted there will likely solve it. Please open a new issue if anything comes up.