Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This file fix a bug in the search form also known as exposed filter.
When using rtl site the form looks is ltr, the attached file views-rtl.css, fix the problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | views-rtl.diff | 404 bytes | moshebeeri |
| #3 | patch-rtl.patch | 18.68 KB | moshebeeri |
| #1 | views-rtl.css_.tgz | 254 bytes | moshebeeri |
Comments
Comment #1
moshebeeri commentedselected file views-rtl.css could not be uploaded, adding a tgz file
Comment #2
dawehnerCould you create a patch file out of it? This would be cool
Comment #3
moshebeeri commentedHi,
The following was patched against 3.0 alpha, but I think it is an over kill,
just extract the perv tgz to the css folder, and it will fit previous versions of views as well, I don't know about ver 5 and 7, since I worked only on 6.
I hope this info will help,
Moshe Beeri.
Comment #4
merlinofchaos commentedSince having to download and untar a file just to look at the changes (and guess what changes you made) is *much* harder than looking at a patch, using a patch is not overkill.
Comment #5
merlinofchaos commentedWhat is overkill, however, is that your patch is completely wrong and is touching files and removing lines of code completely unrelated.
Comment #6
moshebeeri commentedOK, What diff command would you be using,
I just did diff views-6.x-3.0-alpha1 views > patch-rtl.patch
Comment #7
dawehnerI suggest you to checkout with cvs and make a patch with cvs diff: See http://drupal.org/node/323 under cvs example.
Comment #8
moshebeeri commentedThanks Dereine
Comment #9
moshebeeri commentedI hope it will be good to use :-)
Just diff'ed with the following command:
moshe@maxwell:~/tmp/views-HEAD$ cvs diff -upN css > views-rtl.diff
and the output was at: ~/tmp/views-HEAD/views-rtl.diff
so it should be patched against head, sorry for my cvs rust but I am from the svn generation.
Thanks, again, for your help.
Moshe Beeri.
Comment #10
merlinofchaos commentedOk, Drupal's coding standards policy actually says we do not credit authorship in the code via code comments, so I removed that. Also, I added /* RTL */ and /* LTR */ comments as I believe are appropriate.
You are credited in the commit and in the changelog, so your accreditation is preserved. =)