This file fix a bug in the search form also known as exposed filter.
When using rtl site the form looks is ltr, the attached file views-rtl.css, fix the problem.

CommentFileSizeAuthor
#9 views-rtl.diff404 bytesmoshebeeri
#3 patch-rtl.patch18.68 KBmoshebeeri
#1 views-rtl.css_.tgz254 bytesmoshebeeri

Comments

moshebeeri’s picture

moshebeeri commented
StatusFileSize
new views-rtl.css_.tgz254 bytes

selected file views-rtl.css could not be uploaded, adding a tgz file

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Could you create a patch file out of it? This would be cool

moshebeeri’s picture

moshebeeri commented
Status: Needs work » Needs review
StatusFileSize
new patch-rtl.patch18.68 KB

Hi,

The following was patched against 3.0 alpha, but I think it is an over kill,
just extract the perv tgz to the css folder, and it will fit previous versions of views as well, I don't know about ver 5 and 7, since I worked only on 6.

I hope this info will help,
Moshe Beeri.

merlinofchaos’s picture

merlinofchaos commented

Since having to download and untar a file just to look at the changes (and guess what changes you made) is *much* harder than looking at a patch, using a patch is not overkill.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

What is overkill, however, is that your patch is completely wrong and is touching files and removing lines of code completely unrelated.

moshebeeri’s picture

moshebeeri commented
Status: Needs work » Needs review

OK, What diff command would you be using,
I just did diff views-6.x-3.0-alpha1 views > patch-rtl.patch

dawehner’s picture

dawehner
Primary language German
commented

I suggest you to checkout with cvs and make a patch with cvs diff: See http://drupal.org/node/323 under cvs example.

moshebeeri’s picture

moshebeeri commented

Thanks Dereine

moshebeeri’s picture

moshebeeri commented
StatusFileSize
new views-rtl.diff404 bytes

I hope it will be good to use :-)
Just diff'ed with the following command:

moshe@maxwell:~/tmp/views-HEAD$ cvs diff -upN css > views-rtl.diff
and the output was at: ~/tmp/views-HEAD/views-rtl.diff

so it should be patched against head, sorry for my cvs rust but I am from the svn generation.

Thanks, again, for your help.
Moshe Beeri.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Ok, Drupal's coding standards policy actually says we do not credit authorship in the code via code comments, so I removed that. Also, I added /* RTL */ and /* LTR */ comments as I believe are appropriate.

You are credited in the commit and in the changelog, so your accreditation is preserved. =)

Status: Fixed » Closed (fixed)
Issue tags: -RTL, -views, -exposed filter

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +RTL, +views, +exposed filter

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.