Meta tags are not saved for taxomony terms or vocabularies

The cause of the error was the use of a constant that doesn't match the value passed to hook_taxonomy().

I changed the code, and now the hook is implemented in this way:

function nodewords_taxonomy($op, $type, $object = NULL) {
  if (isset($object)) {
    switch ($type) {
      case 'term':
        $type = NODEWORDS_TYPE_TERM;
        $id = $object['tid'];
        break;

      case 'vocabulary':
        $type = NODEWORDS_TYPE_VOCABULARY;
        $id = $object['vid'];
        break;

      default:
        return;
    }
  
    switch ($op) {
      case 'delete':
        nodewords_delete_tags($type, $id);
        break;

      case 'insert':
      case 'update':
        if (isset($object['nodewords'])) {
          nodewords_save_tags($type, $id, $object['nodewords'], TRUE);
        }
        break;
    }
  }
}

Thanks for your report, and the help.

I have marked #673086: Meta tags KEYWORDS and DESCRIPTION are not saved as duplicate of this report.

Hello,

I'm having the same issue with 6.x-1.11. Has the fix been implemented in the version 6.x-1.11 ?

Thanks,

@Summit: What you report is correct; an official release cannot be changed, after it is released.
I was once used to change the referring version to make clear where the issue was fixed, but I was told that it could confuse people who would not know which version had the issue.

I have marked #679852: Meta tags are not saved for taxomony terms as duplicate of this report.

@kiamlaluno -

When you fix a bug, can you please provide a patch against the current release for the rest of us to use? It's much safer to run a patched version of 6.x-1.11 rather than a dev version on a live site.

Thanks,
Jen

Thanks for making the patch file, Jen.

@jenlampton How to apply this patch? please say in simple steps? Thanks

Does anyone know what version to use that works? OR if there is something else that will do the same thing that is stable. This is a real mess to follow.

Will #10 work to fix this version until another stable release happens?

what does this mean? Is there any version of nodewords that works without issue i.e all parts of the module work like saving other pages etc? It is hard to tell when people are making patchs but then they do not apply. Thanks for your hard work.

So just to be clear, am I understanding this correctly?
1. when you do a fix it is applied to the dev version OR
2. Is the fixes applied to the stable versions & then we would just overwrite the stable version and run update php.

The reason I ask is I tried to go to dev from 6x 1.11 and I got errors.

Thank so much for your hard work.

Do you mean January 12? I do not see any releases for January 2nd

It's January 2, 2010; see comment #3. About 7 hours later, a new development snapshot has been created. The official release is the first one created after that date; an official release can be created even 7 days later (or even more), as an official release is usually created when more than one issue is fixed.

You understood correctly when you say that the code is first fixed in a development snapshot; that is how Drupal modules hosted on Drupal.org are developed.

subscribing

subscribing

This NEW version of 6.x-1.11 Does not save any info on other pages, What can be done to fix this, we have a production site and this has really damaged a great deal of work and we are trying to dig out of it. Any input would be appreciated.

"Will #10 work to fix this version until another stable release happens?"

It fixed problem with saving taxonomy term`s metas for me.

"This NEW version of 6.x-1.11 Does not save any info on other pages, What can be done to fix this, we have a production site and this has really damaged a great deal of work and we are trying to dig out of it. Any input would be appreciated."

Why you call 6.x-1.11 new version? It`s release date is 2009-Dec-31. I do not experience such problem with 6.x-1.11 as you mention. I might guess there some wrong settings you applied - try different options and see what happens. Nodewords UI is quite entangled, so sometimes you would get things you not expected.

Marked the following as duplicates:

• #754330: Nodewords won't save my description tag
• #1149338: Taxonomy term description not saved to {nodewords} table when editing term's nodewords description field
• #1189546: Vocabulary desciption not printed
• #1191680: Meta tags not saved for term pages!

Sub :D

Rerolled jenlampton's patch from #10 above for the latest 6.x-1.x branch.

Re-running the last patch against the correct code version.

#31: nodewords-n672096-31.patch queued for re-testing.

Re-applied the commits from this issue, so this should be good now.

subscribing

I can confirm that the latest dev version (6.x-1.x-dev 2011-9-13) works!

The latest dev version ought to solve my 'not-saving' problem but the fieldset still goes under save button. Weight should be fixed as well.