Download & Extend

changes to garykeith.com breaks browscap module

Project:Browscap
Version:4.7.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

The url for getting browser data no longer works

http://www.garykeith.com/browsers/...

should be

http://browsers.garykeith.com/...

The patch included works for both 4.6 and 4.7.

AttachmentSize
browscap-fix.patch.txt1.5 KB

Comments

#1

Looks like there are also some duplicates in the data..

#2

+1
I did exactly the same change to my local copy....

#3

what do you "mean there are also some duplicates in the data"?

#4

+1
This fixed a fresh install of browscap on 4.7 as advertised.

#5

the new web addresses seem to be still good....but no data is imported into mysql for me...

applyed the patch, cleared the cache, deactivated/re-activated the module, runned cron several times, updated the settings page....nothing

does anyone have a clue of why please? Drupal 4.7.2 here

Thank you!

#6

this is because it only imports the datas every x days
--> this means you have to unset the specific variable so that the module thinks it never ran
or simply wait a few weeks... ;)

#7

ahhaaaaa...!

dunno why but truncating 'browscap' tables and browscap line in 'system' table and reactivating the module wasn't enough...picky mod!

thanks for the hint! :)

#8

..but still crawlers are not recognized as such... :(

Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)  Crawler: NO

but i should open a bug report about this maybe..

#9

Version:4.6.x-1.x-dev» 4.7.x-1.x-dev

Can we also commit 4.7 version? Attached is what I used.

Who is the maintainer now?

AttachmentSize
browscap.module.txt 15.11 KB

#10

Status:reviewed & tested by the community» needs work

An actual patch would help.

#11

Status:needs work» closed (won't fix)

4.7 should not be maintained any more.

nobody click here