Hello,
I've just found this module and it's wonderful. Just a suggestion: if the dimensions are not defined but the alignment is, then we can use this. When an image is left/right/center aligned, it will use different imagecache preset or will have different max width.
The scenario is that text is copied from another website and images don't have width/height properties. Similar issue is #433116: Maximum width.
Thanks.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | image_resize_filter-672770.patch | 10.93 KB | jcisio |
| #1 | image_resize_filter.patch | 1.08 KB | jcisio |
Comments
Comment #1
jcisio commentedPatch with hard-coded widths left/right/center alignment.
I think it could be better if we can choose between predefined width with imagecache preset. I can submit another patch for this (hard-coded preset name), and even in settings if you want.
Comment #2
jcisio commentedNew patch. Add options into the admin back-end. Not very beautiful, but usable ;) Not tested with remote image, as I don't use it. If this feature is merged into the module, of course more effort is required :)
Comment #3
quicksketchThis issue is very similar to the issue you already found, #433116: Maximum width. In both cases, this is NOT the intended purpose of Image Resize Filter (which is entirely to read height/width). This feature will not be added, because it is not the intended purpose of the module.
Comment #4
jcisio commentedThanks for your reply. But what do you think about a "Image Autosize filter" module? IMHO it's useful when you migrate your website, or change the layout and your text width is increase. Just change the imagecache preset settings to keep the proportion between image/text.
Comment #5
quicksketchThis module will continue to not do anything but resize images to match the HTML.
Comment #6
jcisio commentedFYI: when this issue was closed, I forked this module. Recently I did a code clean up and realized that I don't need any feature other the preset resize. Therefore I've just released the module at http://drupal.org/project/image_autosize