Since #635334: Patches are not being re-tested automatically is a currently open issue, and since I haven't had the chance for a good RTBC cleansing for about a month, I went through and re-tested each of the patches > 1 week old.

Since #639230: Only change issue status on followup if necessary is also an open issue, all of these patches got demoted to "needs review" from RTBC.

And since this re-test request didn't count as a comment, they did not show up in My issues, and I lost track of them all. :(

I'm not sure this is worth doing; it's probably better to fix the two issues mentioned above. But I figured I'd post it for discussion.

CommentFileSizeAuthor
#6 672850-retest-comment.patch2.01 KBboombatower
#5 672850-retest-comment.patch1.91 KBboombatower
#4 672850-retest-comment.patch1.86 KBboombatower

Comments

boombatower’s picture

boombatower commented
Project: Project Issue File Review » Project issue file test

As other issues are in PIFT queue due to the fact that they run on d.o this should be as well.

I thought about this when I initially wrote code, but decided it wasn't worth the extra time. Definitly doesn't want to make some sort of exception to get it into My Issues. If anything we just need the retest comment to come from the user that clicked re-test (as I thought of), but project_issue api does not support that at current (or didn't then).

So we need an issue created to add support for setting comment user then this can be implemented.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Add re-test requests to "My issues"? » Add re-test requests to "My issues"

Actually, re-test request replies being shown as authored by the person who placed them makes a heck of a lot more sense than the weird "Re-test was requested by @user" stuff we do now. So I'm removing the ? and making this an actual feature request. ;)

Posted an issue at #673108: Add ability to programmatically set username on comments for the comment author stuff.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Add re-test requests to "My issues" » Re-test request comments should come from user who issued them

Better title.

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new 672850-retest-comment.patch1.86 KB
boombatower’s picture

boombatower commented
StatusFileSize
new 672850-retest-comment.patch1.91 KB

Corrected $comment->title to $comment->subject.

boombatower’s picture

boombatower commented
StatusFileSize
new 672850-retest-comment.patch2.01 KB

Remove global $user.

boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.