We repeat a lot of the code for including the BB code, so let's bring it into one function, badbehavior_load_includes().

CommentFileSizeAuthor
#2 673466-badbehavior-simplify-includes-D6.patch5.73 KBdave reid
#1 673466-badbehavior-simplify-includes-D6.patch3.5 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 673466-badbehavior-simplify-includes-D6.patch3.5 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 673466-badbehavior-simplify-includes-D6.patch5.73 KB

Also reduces some code with badbehavior_requirements().

gregarios’s picture

gregarios commented

I tried applying your patch to the rc2 version but it failed like this:

patch < 673466-badbehavior-simplify-includes-D6_0.patch 
(Stripping trailing CRs from patch.)
patching file badbehavior.install
Hunk #1 FAILED at 33.
Hunk #2 FAILED at 55.
2 out of 2 hunks FAILED -- saving rejects to file badbehavior.install.rej
patching file badbehavior.module
Hunk #1 succeeded at 4 with fuzz 1.
Hunk #2 FAILED at 81.
Hunk #3 FAILED at 115.
Hunk #4 succeeded at 167 (offset -2 lines).
Hunk #5 succeeded at 244 (offset -2 lines).
2 out of 5 hunks FAILED -- saving rejects to file badbehavior.module.rej
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Yeah it's made against the current code on the DRUPAL-6--1 CVS branch.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed to CVS.
http://drupal.org/cvs?commit=310024

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.