hi Sam, nice module. I added the lines below and the attached open source xsl and lines below to your output from gsitemap, creates a more readable & easily verified map.

print '<?xml version="1.0" encoding="UTF-8"?>';
print '<?xml-stylesheet type="text/xsl" href="gss.xsl"?>';
print '<urlset xmlns="http://www.google.com/schemas/sitemap/0.84" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.google.com/schemas/sitemap/0.84 http://www.google.com/schemas/sitemap/0.84/sitemap.xsd">';
CommentFileSizeAuthor
#6 gss.xsl11.88 KBfax8
#1 schema+xsl.patch.txt985 bytesfax8
gss.xsl.txt11.94 KBgreg@beargroup.com

Comments

fax8’s picture

fax8 commented
Assigned: Unassigned » fax8
Status: Active » Needs review
StatusFileSize
new schema+xsl.patch.txt985 bytes

the attached patch add support for Google SiteMap XSD making easier to test sitemap validity.
Moreover it adds a link to the gss.xsl file posted above.

To use this patch simply copy the file gss.xsl into your gsitemap folder under modules then apply the patch to your 4.7 gsitemap.module

Hope this helps.

Fabio Varesano

dman’s picture

dman commented

cool idea

Tobias Maier’s picture

Tobias Maier commented
Status: Needs review » Reviewed & tested by the community

great additon

works as expected --> rtbc

if you commit it: please remove the ?> in the end of gsitemap.module
it is not needed - and is note used in drupal core, too

Tobias Maier’s picture

Tobias Maier commented

only one comment: i found this line in the xsl-file:
<link href="gss.css" type="text/css" rel="stylesheet"/>
don't we need this file, too?
please add it if necessary

fax8’s picture

fax8 commented

the gss.xsl file is a merge of the original files available at http://sourceforge.net/projects/gstoolbox
In the original release there were gss.xsl, gss.css, gss.js . The gss.xsl has gss.css and gss.js rules embedded in it.

So.. the
<link href="gss.css" type="text/css" rel="stylesheet"/>
can be safely removed.

Fabio Varesano

fax8’s picture

fax8 commented
StatusFileSize
new gss.xsl11.88 KB

attached there is the updated gss.xls file without linking gss.css

please review and commit.

Fabio Varesano

greg@beargroup.com’s picture

greg@beargroup.com commented

Needs update to XML Sitemap module changes - can use sitemap.org XSD instead of google specific <?>

SamAMac’s picture

SamAMac commented
Status: Reviewed & tested by the community » Fixed

I updated the namespace to the sitemaps.org one, since that is what gsitemap now outputs, and committed this patch to 4.7 dev.

Thanks to everyone who contributed!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)