Optimize Drupal.parseJSON

Is there a reason data is being overwritten and returned?

The patch I posted on the duplicate just returned the result of either the JSON.parse or new Function method. Is there a benefit of data being overwritten and returned?

Is the Function approach better than eval or just different? I think we use single where possible in JS also.

@c960657 IMHO it's a better approach. This is the approach jQuery and other libraries are taking. jQuery uses the same approach (same code, too) as the patches here.

You can check out details on the jQuery switch in it's issue at http://dev.jquery.com/ticket/4680 and you can see the commit at http://github.com/jquery/jquery/commit/90a87c03b4943d75c24bc5e6246630231....

Bump, the patch in #3 still applies.

I'd trust jQuery.getJSON over Drupal.parseJSON anyday, but this is a good first step to make sure they're aligned before replacing them. If they arn't the same, we should eventually take steps to either push the missing functionality back into jQuery, or take steps to align them properly. Maybe instead of won't fix, we push #242642: Drupal.parseJson should be removed in favor of jQuery.getJSON to Drupal 8?

This is a good step for now, though.

jQuery 1.4.1 as been released with New Features and fix for parseJSON.

http://jquery14.com/day-12/jquery-141-released

Reviewed, and this does look like a good solution. Using JSON.parse where possible is totally the right move. And following jQuery is generally a safe bet.

Yay for cool stuff added in jQuery 1.4.1!

Committed to CVS HEAD. Thanks.

Porting a module to D7, I couldn't find any mention of this change in the documentation http://drupal.org/update/modules/6/7

Adding a "Needs Documentation" tag.

Good documentation catch. Fixed. You can see it at http://drupal.org/update/modules/6/7#Drupal.parseJSON

subscribe

this needs backport for drupal 6. After updating jquery to 1.7 in drupal 6, some of the functionality stopped working. eg. ajax link to view older heartbeat messages. A direct replacement of code below works fine.

replace

Drupal.parseJson = function (data) {
  if ((data.substring(0, 1) != '{') && (data.substring(0, 1) != '[')) {
    return { status: 0, data: data.length ? data : Drupal.t('Unspecified error') };
  }
  return eval('(' + data + ');');
};

with

Drupal.parseJson = function (data) {
 // Use native JSON method when available.
 if ( typeof JSON === "object" && JSON.parse ) {
   data = JSON.parse(JSON.stringify(data));
 } 
 else {
   if ((data.substring(0, 1) != '{') && (data.substring(0, 1) != '[')) {
     return { status: 0, data: data.length ? data : Drupal.t('Unspecified error') };
   }
   data = (new Function("return " + data))();
 }
 return data;
};

patch to be ported for drupal 6