The text under "Payment instructions:" when displayed in checkout is preceded by a "To:"

This makes no sense, and it stays there no matter the language of the site.
For example when a site is being displayed in greek the "To:" doesn't mean anything.

Can it be removed? Is there a reason for it being there?

CommentFileSizeAuthor
#6 uc_bank_transfer.diff1.25 KBxibun
#5 uc_bank_transfer.diff2.12 KBxibun

Comments

xibun’s picture

xibun commented
Category: bug » feature

The "To:" is inside a t() function - so you can translate it using the i18n system.

I will consider a removal when I work on the other open i18n issues.

bserem’s picture

bserem commented
Status: Active » Postponed

thanks!

I would like to mention that if you want to translate the "To:" that appears when reviewing the order (cart/checkout/review) you need to search for it without the ":"

Just some info for who might find it usefull :)

xibun’s picture

xibun commented

in case anyone is looking into this... I have marked #761822: To: appeared even "Payment instructions" is filled in as duplicate

xibun’s picture

xibun commented

note: together with todays commit (allowing to theme the output of the bank transfer details) I have separated the ":" from the translatable string "To:".

xibun’s picture

xibun commented
Status: Postponed » Needs work
StatusFileSize
new uc_bank_transfer.diff2.12 KB

here a first patch - goal: only display "To" when "Account name:" is set.

to do:
1) remove the ":" on review page (open to suggestions on how to achieve this)
2) remove "To:" from invoice template (very easy)

xibun’s picture

xibun commented
StatusFileSize
new uc_bank_transfer.diff1.25 KB

re-rolled after committing improved output logic

bserem’s picture

bserem commented

i'm sorry I didn't reply all this time

at the moment I'm serving my country (army) so I do not have the time to test the patch...
hopefully in a few months I'll have more free time, I'll give it a try whenever I can :-)

bserem’s picture

bserem commented

I'm back after many months into Ubercart action!

I see that "To" is still being displayed. Is there any schedule of removing it completely?

xibun’s picture

xibun commented

in the Drupal 7 version I introduced the string "Account owner", this reduces the "problem" further.

when it comes to the Drupal 6 version: I'm against changing the behaviour now, the installation base is quite big and too many shops would need to be adapted. so for Drupal 6 I will only do bug fixes. for Drupal 7 I'm happy to introduce further developments.

bserem’s picture

bserem commented
Status: Needs work » Closed (won't fix)

Thanks for clearing this out xibun.
I don't have experience with D7/UC3 yet but you are right about keeping v6 in a bug-fix only state.
Sadly I've been away for a long time and D7 is quite a mystery to me still...

I'm marking this as closed. I believe if needed that people can hide the "To:" string or even create some code that does that!