currently dblog.admin.inc contains a bug at line 279, since variable $session does not exist any more, it should be $_SESSION['dblog_overview_filter'] instead

function dblog_filter_form($form) {
  $filters = dblog_filters();

  $form['filters'] = array(
    '#type' => 'fieldset',
    '#title' => t('Filter log messages'),
    '#theme' => 'dblog_filters',
    '#collapsible' => TRUE,
    '#collapsed' => empty($session), // <-- this variable was suppressed
  );
CommentFileSizeAuthor
#6 674352-6.dblog_session_variable_update.patch705 bytesjersu

Comments

arhak’s picture

Note that this bug goes away if #582622: provide hook for dblog_filters gets in first, since it uses another approach for determining whether the fieldset should be collapsed/expanded (taking into account every available filter)

arhak’s picture

Status: Active » Needs review
Issue tags: +Quick fix
mr.baileys’s picture

Status: Needs review » Needs work

Can you roll a patch for review/testing?

mr.baileys’s picture

arhak’s picture

I have no CVS copy of Drupal
from the time I download the dev tarball to the time it gets reviewed... around three months pass in between..

nevertheless, I would do it if you insist

jersu’s picture

Status: Needs work » Needs review
StatusFileSize
new705 bytes

Here's the patch that removes the unknown variable $session and replaces with $_SESSION['dblog_overview_filter'].

Status: Needs review » Needs work
Issue tags: -Quick fix

The last submitted patch, 674352-6.dblog_session_variable_update.patch, failed testing.

scott falconer’s picture

Status: Needs work » Needs review
Issue tags: +Quick fix

#6: 674352-6.dblog_session_variable_update.patch queued for re-testing.

Tested locally against current head and this passed. Not sure why filter.test failed, but there was an hour+ delay in testing after submit...so something might have gotten out of date during the wait.

jody lynn’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.