Text format filter list not ordered correctly [#674626]

The order of the filter list on a text format configuration page (ie admin/config/content/formats/2) is not ordered correctly by weight.

If you rearrange the filters and save, then they are displayed again in the original order. The weights are updated and stored correctly in the database.

If javascript is disabled, then you can see the weights are not ordered in sequence (screenshot attached)

Comment	File	Size	Author
#3	674626.patch	2.58 KB	asimmonds
#1	674626_test_only.patch	1.95 KB	asimmonds
	filter_weights_with_js_disabled.png	6.45 KB	asimmonds

Comments

Status	File	Size
new	674626_test_only.patch	1.95 KB

Comment #2

8 January 2010 at 06:01

Status:

Needs review

» Needs work

The last submitted patch, 674626_test_only.patch, failed testing.

Comment #3

asimmonds commented 8 January 2010 at 06:55

Status:

Needs work

» Needs review

Status	File	Size
new	674626.patch	2.58 KB

Patch adds the filter weight to each row in the form, and the test uses a xpath construct to verify the order is correct before and after filter reordering.

Comment #4

aspilicious commented 8 January 2010 at 11:58

It worked fine for me, and to please the people adding stuff to head, my test report:

1) I installed noscript (ff)
2) I went to the page that didn't update the order of the items
3) I moved the items around and saved it, it seemed to be OK
4) I disabled javascript, changed the weight of the items, saved, everything is updated correctly

So, "it works" and it has tests.
If someone can review the "code" then maybe we can make this RTBC