While I originally planned to rather remove all the entity-specific tests and to replace them with tests based on mollom_test.module, recent manual testing and debugging revealed that all of the supported core forms come with their own special requirements. Basically, when considering all of the supported core forms as package, then one could say that they mimic all of the supported scenarios:
* User forms: CAPTCHA-only + Fallback behavior
* Contact forms: Mail integration, reporting of sessions without real entity mapping
* Comment form: Textual analysis without fields, but post mapping of static form elements
* Node form: Textual analysis with fieldable forms and post mapping of fields
For D6, we only use mollom_test to test forms with nested form elements (and proper mapping of those fields) as well as the to-be-done automated post_id mapping (and mollom session saving).
Thus, to complete the test suite, we should extend MollomReportTestCase with tests for protecting and reporting a single node but also mass-operations (mostly identical to comment reporting tests).
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | mollom.node-retain.15.patch | 1.26 KB | sun |
| #13 | mollom.node-data.13.patch | 3.27 KB | sun |
| #9 | mollom.node-data.9.patch | 3.08 KB | sun |
| #6 | mollom.node-data.6.tests-only.patch | 1.8 KB | sun |
| #6 | mollom.node-data.6.patch | 3.03 KB | sun |
Comments
Comment #1
sunComment #2
dave reidComment #3
sunThis test should also verify node's field UI and configuring a custom weight. (#826832: mollom_field_extra_fields() only works for nodes, needlessly loads $mollom_forms)
Comment #4
sunEnsure that mollom_test module is enabled for this test, to verify whether a bogus/non-existing field entity+bundle registered via mollom_field_extra_fields() triggers any errors.
P.S.: Doesn't look like you're working on this, Dave ;)
Comment #5
sunWe should've done this earlier... #1117298-11: Verify that comments can be updated
Comment #6
sunAttached patch adds a new Node module integration test case. And additionally, fixes the kinda major bug of not storing any Mollom session data for newly created nodes.
Comment #7
sunComment #8
dries commentedYuck. Can we create a core issue for this? I'd include the issue number in the @TODO in this patch.
Comment #9
sunAlright, identical patch with @see #1150756: Improve integration with entity form button-level and form-level submit handlers, form/entity (re-)building, and previews
Comment #10
sunCommitted to master. Actually, this patch should apply to 6.x-1.x, too...
Comment #11
sun#9: mollom.node-data.9.patch queued for re-testing.
Comment #13
sunmmm, some differences in D6.
Comment #14
sunCommitted to 6.x-1.x.
Comment #15
sunI've enhanced the Node integration test case to specifically test the reported bug of the support ticket.
While proper saving of Mollom data is closely related, it's not 100% identical. The added test verifies that a node containing profanity is actually retained as unpublished.
Tests are passing for me; should be part of the upcoming release.
Comment #16
sunComment #17
sunThanks for reporting, reviewing, and testing! Committed to all branches.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.