Hi,

I'm using the "Image attach" feature quite regularily to attach new image uploads to other nodes like stories or blog posts. Since over the years a lot of images have been uploaded, it takes over a minute to load the node editing form (several megabytes are loaded). This is caused by an "Image attach" feature which allows to attach an existing image to another node. A while ago I disabled this feature because I liked a faster site better than being able to attach an existing image (the settings page is located at ./admin/settings/image/image_attach).

After upgrading the site from D5 to D6, I got those annoying delays back when loading the node editing form. Finally I located the reason for this: The settings from ./admin/settings/image/image_attach are being ignored (configuration: "Attach existing image", checked "disabled"). On node editing forms with image attach enabled, I still get the option to select an exisiting image and can't disable it (tried to enable, save, then again disable; didn't work).

To make this clear: I don't want to disable "Image attach" completely (I could do this in the module settings, or for a single content type at ./admin/content/node-type/{my-content-type}, I simply want to disable being able to attach existing image nodes to another node (a smarter mechanism to populate the pulldown menu would be fine, also ;).

Disabling this feature used to work on D5, but it doesn't work anymore in 6.x-1.0-beta4 on an upgraded site, so this is a simple bug report.

I'll do a couple of other D5 upgrades in the next days an report back if this issue can be reproduced.

Thanks & greetings, -asb

Comments

joachim’s picture

joachim commented
Title: Image attach settings are ignored after upgrade » Image attach settings are ignored

Confirming on a fresh install.

And: RATS. I thought we'd got this all working :(

joachim’s picture

joachim commented
Status: Active » Postponed (maintainer needs more info)

Is this only on nodes with no images already attached?
If so, see #580864: with 'existing images' disabled, all images show for attachments on new nodes (and please test!)

asb’s picture

asb commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

> Is this only on nodes with no images already attached?

Umm... indeed!

The patch applies more or less cleanly, when running from within /var/www/drupal/sites/all/modules/image/contrib/image_attach:

$ patch < 580864.image_attach.fix-all-images-on-new-nodes.patch
patching file image_attach.module
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 217 with fuzz 1 (offset 2 lines).

Whatever a "fuzz" is, it fixes the problem. Setting this as duplicate.

Thank you very much!

Greetings, -asb