Test of possibly unassigned setting in _filter_html_tips

fgm - January 5, 2010 - 21:59
Project:Drupal
Version:7.x-dev
Component:filter.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

_filter_html_tips() accesses $filter->settings['allowed_html'] without first checking whether that key exists.

As soon as the filtered html text format has been configured, it exists and the problem goes away, but on a fresh install this test fails with a notice.

One possible patch is suggested, which checks for the missing key before using it. It might be yet more valuable to initialize the settings and get rid of the existing (incomplete) test or the proposed (better) one, though ?

AttachmentSizeStatusTest resultOperations
filter_allowed_html.patch818 bytesIdlePassed on all environments.View details

#1

sun - February 9, 2010 - 16:05
Status:needs review» fixed

I think this has been fixed in HEAD already.

#2

System Message - February 23, 2010 - 16:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.