I'm running D6.14, og 6.x-2.0, Mailman Manager 6.x-2.3, User Mailman Register 6.x-2.1, Mailman Groups 6.x-1.1, and Mailman 2.1.9 on CentOS 5.4.
The "Hidden if the User is not a member of the Group" radio button is having no effect. All lists are visible to all authenticated users regardless of what groups the list is linked to and what lists the user is a member of.
The "Auto-subscribe" checkbox is not having any effect. When a user is added to a group, either by the group manager for closed groups or by the user for open groups they are not auto-subscribed.
Perhaps it is a conflict with User Mailman Register, as I find I cannot activate a list in User Mailman Register after linking the list to a group. I have to activate first then link to a group.
Any Ideas?

CommentFileSizeAuthor
#3 mailman_groups_patches.txt8.38 KBjzornig

Comments

jzornig’s picture

jzornig commented

I did some work on the auto-subscribe problem and the following patch fixed it for me

--- mailman_groups.module-6.x-1.1 2010-01-07 13:20:12.000000000 +1000
+++ mailman_groups.module 2010-01-07 13:23:04.000000000 +1000
@@ -309,7 +309,7 @@

// Do the subscribe via User Mailman Register if available, otherwise use Mailman Manager function.
if (is_callable('_user_mailman_register_subscribe_update')) {
- _user_mailman_register_subscribe_update($user, $list, 3, 0, $user->mail, NULL);
+ _user_mailman_register_subscribe_update($user, $list, array('new_status' => 3, 'old_status' => 0), $user->mail, 0, NULL);
}
else {
if (!_mailman_groups_checkfunc('_mailman_manager_subscribe')) {

andy inman’s picture

andy inman commented
Status: Active » Needs work

The feature used to work, so maybe UserMailmanRegister has changed. Ideally there needs to be a defined API for the UMR and Mailman Manager modules - that would need agreement from the maintainers of those modules. Without a defined API there will always be the danger of incompatibilities across versions. So, jzornig or others, would you like to take on the task of discussing it with them? :)

jzornig’s picture

jzornig commented
StatusFileSize
new mailman_groups_patches.txt8.38 KB

I've been continuing to work on this and now have the lists being hidden correctly on all user profile and registration forms. I'm including my patches which cover auto-subscribe, auto-unsubscribe and hiding lists for groups the user is not a member of. Hopefully it will be of use to someone.

andy inman’s picture

andy inman commented

Thanks - can anybody else confirm results with this patch please?

andy inman’s picture

andy inman commented

New maintainer joining, hopefully he will have time to take a look at this!

anschauung’s picture

anschauung commented

Thanks for the patch, @jzornig.

I've incorporated most of the profile edits and URM API changes into the development branch, and took care of the other changes (auto-unsubscribe) in an earlier update.

Please let me know if you see any other problems!

andy inman’s picture

andy inman commented
Assigned: Unassigned » anschauung
uayebforever’s picture

uayebforever commented
Status: Needs work » Reviewed & tested by the community

I have tested the patch in #3 against 1.1, and it appears to fix the problem, at least with og-2.3.

However, this patch does not seem to be applied to the 2.x-dev branch as suggested by #6, and the issue remains. Clearly the solution provided by #1 (which matches the function _user_mailman_register_subscribe_update in user_mailman_register) must be part of a working fix.