When you are scrolled down on a page and then open the overlay, the overlay is below the toolbar while loading. Easy fix: call window.scrollTo earlier.

CommentFileSizeAuthor
overlayloading.patch1.09 KBcasey

Comments

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Ok tested on every browser I have.

This works and only moves one line of code!

RTBC

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

Hm. I can see the bug you're talking about, but this patch seems to give me a jarring "whiplash" feeling, and the screen flashes a bit when it moves the window up. Not sure this is an improvement. Let's see what others say.

casey’s picture

casey commented
Title: Overlay below toolbar while loading » Overlay outside of viewport while loading

To reproduce:

1. Overlay + toolbar enabled
2. goto a long page like admin/modules (type path manually to prevent it opening in overlay)
3. scroll down to bottom of page
4. click another link in toolbar

While loading, you'll only see the overlay background. The overlay dialog is invisible because its outside your viewport.

jide’s picture

jide commented

To avoid the "screen flash" webchick describes, this could be animated.

aspilicious’s picture

aspilicious commented

I think something changed here, cause when I'm doing what casey's saying I don't go back to the overlay.

Better explanation:
1. Overlay + toolbar enabled
2. goto a long page like admin/modules (type path manually to prevent it opening in overlay)
3. click another link in toolbar
4. I'm not in the overlay I stay outside, this isn't a bad thing but it's a change I think

Maybe this is caused by applying #676008: Overlay's Loading 'spinner' graphic often not visible because it is displayed outside the viewport

casey’s picture

casey commented

That is supposed to happen since #650528: Overlay should not appear when an administrative page is being viewed in the parent window.

Point of this issue is that when you scroll down on long pages and then open the overlay you won't see the overlay open.

casey’s picture

casey commented
Status: Needs review » Closed (fixed)

This problem does not exist no more since #668640: Overlay shouldn't be based on jQuery UI Dialog.