Password encryption and settings in 4.7

DeFr - June 6, 2006 - 16:38
Project:roundcube webmail integration
Version:HEAD
Component:Code
Category:bug report
Priority:normal
Assigned:DeFr
Status:closed
Description

This patch allow the encryption of password in Drupal 4.7 ( using base64_encode and base64_decode appropriatly so that only a somehow plain text representation of the encryption gets stored in the database ) , and converts the hook_user update handler to change the value in a 4.7-ish way.

Another problem in 4.7 was the setting page, which was completly blank. Simply returning the form instead of calling drupal_get_form on it does the trick.

Finally, I've changed the rcmail_page function so that the settings are used.

P.S. : Do note that while bug 67519 exists, editing the form without re-filling the password field leads to it's value being lost. This was already the case before my changes. This can be fixed by either applying the patch I've put in bug 67519 or by switching the password to be shown in an input field ( '#type' => 'password' becomes '#type' => 'textfield' ).

AttachmentSize
rcmail.patch.txt4.85 KB

#1

polyformal_sp - June 12, 2006 - 08:06

I'll check the patch and prepare for check in cvs asap.
Nice job, thanks.

#2

polyformal_sp - June 12, 2006 - 10:24
Status:needs review» fixed

cvs ist up to date. I decided to require the password every time a user is updating his settings, instead of displaying the password in cleartext.

#3

Anonymous - June 26, 2006 - 10:30
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.