The addition of settings to this module is great, but I believe there should be a separate permission to administer them. I don't want my content editors changing the settings just because they have "administer nodes" permission. So I propose the addition of an "administer node form rearrange settings" permission. See the attached patch. (Note, the patch includes a few extra lines because my code editor strips extra spaces from the end of lines on save, and there were some of those in the module file.)

CommentFileSizeAuthor
#4 node_form_rearrange-676122.patch1.89 KBtraviscarden
node_form_rearrange.patch2.11 KBtraviscarden

Comments

chiddicks’s picture

chiddicks commented

After examining it, I'd actually recommend using the 'administer content types' permission. You wouldn't be able to actually modify the node form unless you have the ability to modify the content type, so it makes sense to me to make this settings page contingent on that too. I'm just suggesting that to do our part in reducing the number of permissions cluttering the permissions page.

Any thoughts?

traviscarden’s picture

traviscarden commented

I think that makes good sense, actually. That makes me think that it might also make sense to put the settings on the edit content type screens instead of having a whole separate menu item for them, but that's another issue. ;)

chiddicks’s picture

chiddicks commented

If you code it, I'll commit it! Ha ha.

If you've been testing the current dev version, and it's been working well, I'd like to roll out a new release.

traviscarden’s picture

traviscarden commented
StatusFileSize
new node_form_rearrange-676122.patch1.89 KB

Here's a patch for the permission change, rolled against HEAD. I look forward to a new release! :)

chiddicks’s picture

chiddicks commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.