This patch lets you create contributed cache interfaces for Drupal. Files, Berkeley DB, memcached -- you name it.

CommentFileSizeAuthor
#7 separate_cache_2.patch12.17 KBchx
#2 separate_cache_1.patch11.9 KBchx
#1 separate_cache_0.patch9.57 KBchx
separate_cache.patch5.02 KBchx

Comments

chx’s picture

chx commented
StatusFileSize
new separate_cache_0.patch9.57 KB

I forgot to add the new file.

chx’s picture

chx commented
StatusFileSize
new separate_cache_1.patch11.9 KB

Made bootstrap a bit more fine grained and made 'fastpath' possible. The file caching already does it, and likely all non-SQL caching mechanisms will want it.

jeremy’s picture

jeremy commented

Okay, so you're proposing that the 'cache_inc' variable is used to determine which cache.inc file to use? The problem being, you need to know the cache type before you can retrieve variables, otherwise you're dependant on pulling this information out of the database which means a fastpath is not possible.

To solve, I would suggest that the location of cache_inc (as well as the enabling/disabling of a fastpath) be configured in settings.php.

chx’s picture

chx commented

Jeremy, if you call variable_get before variable_init is called then it'll pull from $conf which is set in settings.php.

dries’s picture

dries commented

I like this approach. :-)

I hate the name 'FASTPATH' though -- it isn't very descriptive. Also, the existing name 'PAGE_CACHE' is no longer accurate. FASTPATH also enables 'page caching'. Maybe we need to use DUMB_PAGE_CACHE and SMART_PAGE_CACHE, or EARLY_PAGE_CACHE and LATE_PAGE_CACHE?

(Also, if the database caching could use dumb or early page caching, we'd probably see significant performance improvements as well. Cfr. with Jeremy's fastpath file caching.)

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

I did a code review and quite some testing. Everything is in order.

Instead of fastpath and page_cache, i also like EARLY_PAGE_CACHE and LATE_PAGE_CACHE. I rerolled with this naming, and and set to RTBC.

chx’s picture

chx commented
StatusFileSize
new separate_cache_2.patch12.17 KB

Moshe seems to have forgotten the file. I have rerolled with the suggested name change.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)