Hi,
So, having a website with blockbars in it fails the xhtml validation. I have errors like:

nowrap" is not a member of a group specified for any attribute
document type does not allow element "div" here
there is no attribute "align"
an attribute value specification must be an attribute value literal unless SHORTTAG YES is specified
CommentFileSizeAuthor
#3 blockbar.patched.module9.46 KBNNonexistent
#1 blockbar_valid.patch4.88 KBNNonexistent

Comments

NNonexistent’s picture

NNonexistent commented
Status: Active » Needs review
StatusFileSize
new blockbar_valid.patch4.88 KB

At least it passes validation now, but I think code could be greatly improved.

Julien PHAM’s picture

Julien PHAM commented

Don't you have an already patched .module file? Your patch file is kinda strange, there's no + and - signs in it, just '!' signs...

NNonexistent’s picture

NNonexistent commented
StatusFileSize
new blockbar.patched.module9.46 KB

Patching passed fine from original files of 4.7.0 version.

Nevertheless, I've attached patched blockbar.module.

Den-I’s picture

Den-I commented

Thank You NNonexistent for Your great work. Patched blockbar.module work fine.
For me there is remain two warnings in HTML validation:
1.<div class="blockbar-content blockbar-1-content" id="_block1_sub1" style="display:none;">

ID "_block1_sub1" uses XML ID syntax

2.<h2></h2>

empty tag

I think, it case blockbare remove block header information, but remain header tag h2, that bring to presence, for example, small bar in the header of blockbar area, if headers background of the blocks was separate by color.

mbutomax’s picture

mbutomax commented

Sorry but the patch has also another boring problem.
If you edit a page and then confirm the modification, a white page will appear.
After reloading any page of the site you face this error:
Cannot modify header information - headers already sent by (output started at [drupalROOT]/modules/blockbar/blockbar.module:238) in [drupalROOT]/includes/common.inc nella riga 266.