The per-preset permissions always drive us crazy clicking through all of them, and we've never built a site that actually needed to restrict imagecache preset access.

I'm thinking of a patch that does the following:
- Add a setting to enable per-preset permissions, disabled by default.
- Add an update to enable the permissions, to not change existing behavior on current sites.
- Adjust uses of user_access and hook_perm to check for the new variable's setting.

Sound worthwhile?

CommentFileSizeAuthor
#2 privatefiledoc-678066.patch613 bytesbkosborne

Comments

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Surprised this received no attention. The per-preset permissions always confused me anyway - and I found out from this thread: http://drupal.org/node/263126, that they only apply to private file systems anyway.

Aside from Jody's proposition above, documentation should at least be added indicating that the per-preset permissions only apply for private filesystems.

edit: the README has
"NOTE: Each role that wishes to view the images generated by a
particular preset must be given permission on the admin/user/permissions
page."
This should be changed to indicate it only works for private filesystems...

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
StatusFileSize
new privatefiledoc-678066.patch613 bytes

updating the README...

sandrewj’s picture

sandrewj commented
Status: Active » Reviewed & tested by the community

There are other issues that suggest a single master permission, but the readme update is fine here.

Marking as reviewed and tested as this is a text file.

sandrewj’s picture

sandrewj commented
Title: Allow disabling of per-preset permissions » update readme regarding preset permissions
Component: User interface » Documentation

Since there is already an issue #558820: "View all imagecache presets" permission regarding the creation of a "view all presets" permission, which would do what the original post recommends, I am changing the title to reflect a documentation change here.

fizk’s picture

fizk commented
Issue tags: +ImageCache 3

Marking as ImageCache 3.x Todo.