Same deal as #636386: Add Saudi Arabia to the list of countries.

Uploading this from http://www.ubercart.org/contrib/9507 in case it got lost in the shuffle.

Note: Absolutely zero commit credit goes to me, only to kahenya, the original author.

CommentFileSizeAuthor
#1 rwanda_646_1.cif_.txt802 bytestr
rwanda_646_1.cif_.txt1.84 KBwebchick

Comments

tr’s picture

tr commented
Status: Needs review » Needs work
StatusFileSize
new rwanda_646_1.cif_.txt802 bytes

That has the old Drupal 5 / Ubercart 1.x format for .cif files. In particular, it doesn't properly deal with the 'serial' field type for zone_id and doesn't work with PostgreSQL. Attached is a re-roll of the file in the current Drupal 6 / Ubercart 2.x format.

Note, I have installed this on my test server to make sure it doesn't have any syntax errors, but I can't evaluate the content of the zones or address format for Rwanda because I don't know anything about postal regulations in that country. In particular, reading http://en.wikipedia.org/wiki/ISO_3166-2:RW suggests that both the 2-character codes and the province names in this .cif file are wrong, so I'm marking the status as "needs work".

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Wow, thanks! I just noticed when I tried to import this that I got a fatal error. And the voila! A new file was there! :D

Is the ISO 3166-2 standard what's being applied in these files? I'm having a hard time telling. For example, ">Finland defines 6 areas, yet in finland_246_1.cif, it says:

  // VALUES = Country ID, Country Name, 2-digit Code, 3-digit Code, File Version
  db_query("INSERT INTO {uc_countries} VALUES (246, 'Finland', 'FI', 'FIN', 1)");

  // FI has no postal zones in the Ubercart sense

And actually, I just looked at the US one, and I /know/ that's not right. :) http://en.wikipedia.org/wiki/ISO_3166-2:US

When I send a letter to Mom, it goes to 55904, not US-MN.

tr’s picture

tr commented

The country ID (646 for Rwanda) is definitely the ISO 3166-1 value. I don't have a reference for the zone value, but I know we've talked about this in the past, and I remember the consensus was to use the ISO 3166-2 value for the zone with the initial country-specific prefix removed. So for US-MN it would be just MN. But for Rwanda that would be 01, 02, etc., which don't sound like codes that are really used when addressing packages. So I don't know for sure. But at least the ISO 3166-2 *names* should be used? e.g. "Ville de Kigali instead of "Kigali Province" etc.

To me, what's important is that packages are addressed the way the locals and the local postal system expects them to be, despite what it may say in the ISO standard.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Yeah, good point. I left a comment for the maintainer of the original file at http://www.ubercart.org/contrib/9507 in the hopes that they might be able to respond here somewhat more authoritatively.

tr’s picture

tr commented
Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Needs work » Fixed

Fixed in 7.x-3.x-dev by #1070342: Add missing CIF files

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.