Hi jbrown,

Attached is code cleanup patch to bring Type-local nids inline with Drupal coding standards, improve readability and pass the Coder tests.

I am currently looking into an issue which causes the [lnid] token to be unavailable to FileField Paths (#678218: FileField Paths issue with Type-local nids.), which is most likely related to [#349524 ], and if I do find a necessary fix to be made in Type-local nids it will rely on this patch.

Cheers,
Deciphered.

CommentFileSizeAuthor
type_local_nids-6.x-1.x-dev-code_cleanup-0.patch6.85 KBdeciphered

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

A quick update regarding the issue I was looking into.

It was not related to #349524: lnid not available in presave hook as I first assumed, it was actually related to another old Type-local nids issue: #486884: Type-local nids runs too late..
I submitted a patch to adjust the weights on install and added a hook_update_N() for anyone with the module already installed.

Hope you consider committing these two patches.

Cheers,
Deciphered.

jbrown’s picture

jbrown commented
Status: Needs review » Fixed

Implemented some of your changes: http://drupal.org/cvs?commit=316084

I like code to be spaced out and I have no comprehension whatsoever of the Drupal convention of putting an entire SQL query on one line.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.