Drupal.wysiwygAttachToggleLink hijacks my click event :(

I'll look into clearing just that function later this evening. Would triggering on something like onMouseUp work instead? Should be more similar to onClick compared to onBlur, I think.

This patch should do the trick.

On a further note, we should take implementing some "onComplete/doneLoading/whatever" events, and relaying them through our API, into consideration for Wysiwyg 3.x. Having to rely on events triggered by this toggler link is not an optimal (and in most cases probably not a useful) solution considering the asynchronous nature of the editors.

I took a look at your code a few hours ago and saw those loops. They seem to work but I'm a bit concerned about the check for Drupal.wysiwyg.instances[field].editor, that being set to something other than 'none' is no guarantee the editor is done loading and the API is ready for use.

If you don't mind, I'll try contacting you once we have the relevant parts of 3.x implemented so you can have a chance to review it and try it out before an official release. As far as I know, only your module interacts with the editors in this way so you have a better idea about the requirements on this module than we have.

EDIT: Your reply got in while I was typing, will respond in a sec. Don't mind the status change.

I didn't notice the problems that appeared when toggling multiple times until now. I have no clue why this happens but it might have something to do with the function being redeclared every time during toggling. I don't feel like digging that deep into jQuery to find out where this goes wrong, my head hurts enough already and there's an easier way around this.
I moved the callback outside the function and now it appears to work no matter how many times I toggle it. Tested with multiple editors on the page at the same time just to be sure the closures created by jQuery for our parameters work like they should.

+++ wysiwyg.js	10 Jan 2010 22:35:03 -0000
@@ -153,28 +153,8 @@ Drupal.wysiwygAttachToggleLink = functio
+    .unbind('click', Drupal.wysiwyg._toggleWysiwygCallback)
+    .bind('click', {'params': params, 'context': context}, Drupal.wysiwyg._toggleWysiwygCallback);

@@ -182,6 +162,34 @@ Drupal.wysiwygAttachToggleLink = functio
+Drupal.wysiwyg._toggleWysiwygCallback = function(event) {

1) We should namespace those event bindings, i.e. click.wysiwyg

2) Do we need to wrap to keys in quotes?

3) Holy cow. I wasn't aware of that data-passing feature of jQuery :)

4) We want to rename that helper function to .toggleEditor() or similar.

Powered by Dreditor.

1) Makes sense.

2) That was for readability, {params: params, context: context} looked odd (but is technically valid) and I wanted to keep the key names the same as the variables to minimize confusion. I'll remove the quotes if you want.

3) Yeah, it's pretty neat. =)

4) I don't mind a name change, but removing the _-prefix (making it 'public') would be a lot easier if it was 'set' instead of 'toggle', if you see what I mean. 3rd party code has little use for a toggle switch if they can't easily read the starting or ending states, nor find out when the operation is done (half the time it will be asynchronous). The function works for our internal use because we keep a reference to the parameters read from the radio buttons (Drupal.settings in D7). Making it public should also mean it's fairly straight forward to use. How params works is a bit of a wtf if all you want to do is make sure no editor is loaded when, for example; doing AJAX operations on a field. One must first check with Drupal.wysiwyg.instances[field].editor to know the status of the editor, and if it's disabled one also needs to use .getParams(theCorrectElement) to get the correct values, then override params.status. See the last patch I wrote for #527622: WYSIWYG editors disappear after node body rebuild and switching filter does not bring them back for reference.

If all this could instead be rewritten to Drupal.wysiwyg.enableEditor(field) (asynchronous, possibly with callback in 3.x) and Drupal.wysiwyg.disableEditor(field) (synchronous) I'd be happy to do it. It would also simplify the Markup Snippets patch and managing a toggle callback for the Rich edit link would be easier as well. A rewrite like that would probably be easiest to base of the D7 implementation since it has already decoupled the radio buttons with the actual parameters. Maybe time to port that to D6?

Yikes, 2am again... Where is all the time going???

Works nicely and should no longer remove other's handlers. RTBC.

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.