Path alias link is below submit button on taxonomy term add

This is the result of removal of the identification fieldset in #664022: Remove Identification fieldset from term add

Trying to fix this appears to be harder than it looks, if we still want the path textfield to show just under the term description textarea.

Patch attached attempts to adjust the #weight of the path alias textfield by using a #after_build callback on the form.

I'm not entirely happy with this, too much of a hack IMO, may be it's easier to do if this and the term's 'advanced options' were in a vertical tabs arrangement similar to /node/add. Ideas?

Lets try something simpler, instead of a #after_build, just manually apply weights to the form elements.

Better one that uses our $form['actions'] structure to contain the form's buttons.

Same patch, without the broken #access in 'delete'.

Yes, that's much better. Thanks Damien. :)

Committed to CVS HEAD. Thanks.

#499192: Fix display and forms for "Fieldable terms" does the job of exposing the non-Field elements in the taxo term form.

The weights 0 and 10 assigned by the patch committed here will clash with Fields with user-assigned order. As with any form that includes Fields (and the 'reorderable' behavior that comes with those), we cannot stick hardcoded form elements at fixed weights in the middle of user-reorderable fields.

So either:

a) we make those elements ('relations' fieldset and 'URL alias' input) reorderable on the 'Manage fields' page by exposing them in hook_field_extra_fields().

b) we don't make we assign them heavy weights so that they automatically stick at the bottom of the form, just above the submit button. Less cruft for the user to take care of on 'Manage Fields' page. That's what we did for the Vertical Tabs at the bottom of node forms.

Thoughts ? - We can include the changes in #499192: Fix display and forms for "Fieldable terms" , but raising the topic here.

Oooh. +1000 for having path.module implement hook_field_extra_fields().
I opened #687994: Add hook_field_extra_fields() implementation to path module for this so I'll go ahead and mark this as fixed.

Agreed for the 'URL alias' input.

This leaves the question of the 'relationships' fieldset. Reorderable, or always at the bottom of the form ?