Posted by BryanPflug on March 29, 2004 at 8:57pm
18 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | node system |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
| Issue tags: | Usability |
Issue Summary
Many nodes under drupal support separate 'Preview' and 'Submit' functionality. Some require 'Preview' prior to 'Submit'.
The Submit button, on previewed pages, appears at the bottom of the markup text. This makes sense when you are still making changes to a previewed page. However, when you like the way it looks, you would rather not have to scroll down to click it.
I propose adding a second 'Submit' button at the bottom of the rendered page, and above the user's source for that text, on previewed pages, so that users can use either button. The functionality would of course be the same for both buttons. Just a nit, but would be nice for users.
Comments
#1
A related problem is that some users, we've found, fail to realize they're seeing a preview rather than a published node and click away rather than scrolling down and clicking Submit. It doesn't help that we display the node links along with the preview, enabling another way to click away from the task at hand.
#2
those node links are gone, but this issue is still valid and adding buttons on top still sounds like a good idea to me.
#3
I think if nothing else, having something like this in theme_node_preview() would be good. And a submit button on top is good too! +1
<?phpdrupal_set_message(t('Your changes have not yet been saved. Take a look at the preview of your post below and if you are satisfied, save the changes by clicking Submit button.'));
?>
Side-issue #1: On a side note, it doesn't seem that any drupal_set_message() in theme_node_preview() is being displayed while previewing. Can anyone confirm this before I submit a bug?
Side-issue #2: Also, I just previewed this post and I don't see a preview. What's the deal with that?
#4
Side-issue #1: My bad. The message is set when previewing, but #2 is still valid: Preview on this page is really not working.
#5
#6
I don't see any reason this is "fixed".
#7
A good idea worth exploring further...
#8
Has there been any update to the issue of the submit button being a the bottom of the page, requiring a lot scrolling down? I'm not seeing anything posted on it since Summer 08, but it's still a prevalent issue in creating our site. I'd love to see a submit button on top. Thanks!
#9
Would it be sufficient to preface the preview with text that says something like "Here is a preview of your @node_type. If this appears acceptable, scroll to the bottom and press submit. Otherwise continue with your modifications. This @node_type will not be created until you click submit."
#10
Just adding my two bits of a vote for options supplied with Content type to control whether preview is required, and to allow the repositioning/duplication of the Submit button. Drupal gives me carpel tunnel from all the scrolling one must do! I'm just kidding, but Submit right next to the preview would be a really nice feature.
#11
I would like to stress the need and usability of adding a submit button at the top of node edit form.
The amount of scrolling needed in Drupal UI is one of the main complaints I get from customers, but scrolling could actually be eliminated 100% for a big portion of edits (when just adding a title and content) by always supplying with another save button at the top of the page. This is how many other systems I've seen has it, and is what feels most sensible IMO.
#12
subscribe (yes, I know it's annoying)
#13
Patch adds a Save button between the preview and the node form.
#14
Just as another option, this patch includes the dsm from #3.
#15
Ignore #14. This patch puts the message in theme_node_preview() like #3 originally suggested. #13 is still a good message-free option.
#16
The last submitted patch failed testing.
#17
Re-roll for pifr with screenshot for visual assistance.
#18
I like this simple change a lot. Lets commit something here and get on with our lives. It has been over 5 years!
I would think this is not needed. Does save still work without it?
'#submit' => array('node_form_submit'),#19
No, save does not still work without it. The "original" save button on the bottom has the same #submit item as well.
I tweaked it a bit to make the message at warning level instead of status (that means it'd be in yellow in Garland instead of bulleted in green).
#20
I'm unsure if a warning is appropriate here but thats really a minor point. RTBC.
#21
Whoever commits it can pick either #17 or #19 then. They're identical except for the new notice's status level.
#22
This is addressed by #472126: D7UX: Move buttons to right area, add content and meta selector. I like the direction that #472126 is going in better, so let's re-group over there.
#23
Re-opening this - that other issue is stalled, this one deals with only a subsection of what's discussed there and I don't think they really conflict.
#24
adding tags
#25
I hate to add something rather than getting this committed already, but another possibility is a greyed "PREVIEW" watermark over the content, similar to the way the Zen theme does with "UNPUBLISHED". That way, even if they skip over the green message (as many do out of habit), they'll still notice the watermark.
#26
The last submitted patch failed testing.
#27
Can someone reroll this? Looks like it would be a great improvement.
#28
so... i was going to reroll this, but it didn't apply cleanly to the current version of HEAD for me, i'm assuming there has been a lot of changes since the patch was originally posted:
patching file modules/node/node.pages.incHunk #1 succeeded at 115 with fuzz 2 (offset 3 lines).
Hunk #2 FAILED at 380.
1 out of 2 hunks FAILED -- saving rejects to file modules/node/node.pages.inc.rej
patching file modules/node/node.test
Hunk #1 succeeded at 281 with fuzz 2 (offset 27 lines).
#29
subscribe
#30
Still valid, we want to further improve content creation workflows for D8.