Posted by Pasqualle on January 8, 2010 at 8:19pm
| Project: | Omniture Integration |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
improvements:
1. SC variables created from taxonomy terms moved to sub-module
2. new SC variables (in sub-module): page title, user name
| Attachment | Size |
|---|---|
| D7_port_omniture.patch | 27.42 KB |
Comments
#1
patched version: [EDIT: download link removed]
#2
in omniture_basic.module
'und'should be replaced withLANGUAGE_NONE#3
#4
Awesome - thanks Pasqualle. I'm not using the module and so not in a position to test this out right now. Pending a review from someone who is using it I could also just commit this and make a dev release to help others testing it.
#5
If I get chance ill review tomorrow, there are another couple I need to review also.
#6
the original patch was not fully committed.
problems:
function omniture_page_alter()
wrong function description
if (arg(0) == 'admin' && $track <= 0) {this must be ||
function omniture_admin_settings()
1/H.13--NS/0old value; should be H.20.3
->execure();...
roless
...
$role-rid
typo
$stringremove unused variable
'#title' => $role->name,replace with '#title' => $role_name,
remove trailing spaces..
please remove .project file from cvs (from all branches)
#7
Can you provide a new patch?
#8
sure
#9
I have commited this change, I did notice one issue thought and that was with the page_alter() function, and its been updated to work with php 5.3
A new dev version should be rebuilt shortly for testing.