improvements:
1. SC variables created from taxonomy terms moved to sub-module
2. new SC variables (in sub-module): page title, user name

CommentFileSizeAuthor
#8 679320-8-D7_port_omniture.patch4.07 KBpasqualle
D7_port_omniture.patch27.42 KBpasqualle

Comments

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs review » Active

patched version: [EDIT: download link removed]

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

in omniture_basic.module
'und' should be replaced with LANGUAGE_NONE

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Active » Needs review
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Awesome - thanks Pasqualle. I'm not using the module and so not in a position to test this out right now. Pending a review from someone who is using it I could also just commit this and make a dev release to help others testing it.

Race.it’s picture

Race.it commented

If I get chance ill review tomorrow, there are another couple I need to review also.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs review » Needs work

the original patch was not fully committed.

problems:
function omniture_page_alter()
wrong function description

 if (arg(0) == 'admin' && $track <= 0) {

this must be ||

function omniture_admin_settings()

1/H.13--NS/0

old value; should be H.20.3

->execure();
...
 roless
...
$role-rid

typo

$string

remove unused variable

'#title' => $role->name,

replace with '#title' => $role_name,

remove trailing spaces..
please remove .project file from cvs (from all branches)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Can you provide a new patch?

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs work » Needs review
StatusFileSize
new 679320-8-D7_port_omniture.patch4.07 KB

sure

Race.it’s picture

Race.it commented

I have commited this change, I did notice one issue thought and that was with the page_alter() function, and its been updated to work with php 5.3

A new dev version should be rebuilt shortly for testing.

Status: Active » Needs review

Correcting issue status, see #2125263: Issue status not taken from last comment during D7 migration.

The last submitted patch, D7_port_omniture.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 8: 679320-8-D7_port_omniture.patch, failed testing.

The last submitted patch, D7_port_omniture.patch, failed testing.

The last submitted patch, 8: 679320-8-D7_port_omniture.patch, failed testing.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Issue summary: View changes
Status: Needs work » Closed (fixed)