$rows[] = array(
        format_date($job->created),
        t($job->description, array_filter(unserialize($job->arguments), 'is_scalar')),
      );

watchdog('job_queue', 'Ran queued job "!description"', array('!description' => t($job->description, array_filter($arguments, 'is_scalar'))));

Why are we sending the list of function arguments on to t()? This is resulting in output as per the attached screenshot.

CommentFileSizeAuthor
#4 679340-job_queue-4.patch1.1 KBc4rl
#3 679340-job_queue-3.patch457 bytesc4rl
#2 fix-the-wonky-679340-2.patch344 bytesjoelstein
Screenshot-7.png26.25 KBbrianV

Comments

svogel’s picture

svogel commented

Oh yes. I just stumbled over that too.
Subscribing :-)

joelstein’s picture

joelstein commented
StatusFileSize
new fix-the-wonky-679340-2.patch344 bytes

This was causing me headaches, too. The arguments are indexed with numeric values (0, 1, 2, etc), so if you have any numbers in your description, they will be output. Very "wonky" indeed. I recommend we remove it. The attached patch does so.

c4rl’s picture

c4rl commented
Title: Output of job descriptions is wonky » Job descriptions shouldn't be translated with arguments used for the job function
Status: Active » Needs review
StatusFileSize
new 679340-job_queue-3.patch457 bytes

I'd argue that the description shouldn't be translated at all in the job queue module. You should translate it yourself when calling job_queue_add().

Tweaking patch #2 slightly.

c4rl’s picture

c4rl commented
StatusFileSize
new 679340-job_queue-4.patch1.1 KB

Revised patch handles watchdog() as well

brianV’s picture

brianV commented
Status: Needs review » Needs work

c4rl: Nice patch. However, I do think the watchdog call with the next 'Ran queued job' should run through t() as that is english text.

c4rl’s picture

c4rl commented
Status: Needs work » Active

I see what you mean. I have a few remarks and realizations which may influence a different kind of patch.

First of all, in dblog.module, watchdog messages are automatically sent to t() (see dblog_overview() and _dblog_format_message()), so I believe the English text should be fine.

At first it made sense to me that the usage of the function should send the translated string as an argument of job_queue_add().

For example: 

// Description is second argument -- send translated string.
job_queue_add('drupal_mail', t('Sending !key mail to @address', array('!key' => $key, '@address' => $address)), array('my_module', $key, $address, language_default(), array('foo' => $foo)));

In this fashion, job_queue only has to deal with the translated descriptions. This brings up a problem, however, that the descriptions are then not translatable -- a multilingual admin interface isn't possible.

Arguably (no pun intended), there should be a separate parameter for job_queue_add() just for the parameters to be translated. I suppose in order to *not* break the API outright, we could accept the $description argument as either (1) an untranslated string or (2) an array of arguments to be used in t().

If this makes sense, I can probably roll the patch later this week to demonstrate.

buzzman’s picture

buzzman commented

any progress plz? bumping ...

manuel garcia’s picture

manuel garcia commented

I agree with @c4rl in #6, please do roll a patch with that =)

josephsmeadows’s picture

josephsmeadows commented

Me too getting same when i use this arguments.

Thank you.
Job description