Posted by boombatower on January 9, 2010 at 12:04am
| Project: | Project Issue File Review |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed (fixed) |
Issue Summary
--
| Project: | Project Issue File Review |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed (fixed) |
--
Comments
#1
To be consistent with other perms in Drupal, shouldn't it be "Administer PIFR"?
#2
Yea, that makes sense.
#3
It looks like some of the other permissions in that module are more similar to your previous permission name?
From the patch:
'pifr add test client','pifr manage environments',
'pifr manage clients',
- 'pifr administer',
+ 'administer pifr',
'access administration pages',
Hmmm. I guess those are in a different module?
#4
That is in the test "pifr_server.test".
#5
Yes, but presumably those are other permmissions that the test is using, that come from PIFR or a related module? I'm just saying that those other permissions are using the format "pifr whatever" rather than "whatever pifr". Also, I think most permissions don't abbreviate the module name, so it would be even better to be "administer project issue file review".
But it's your module. :)
#6
Update the rest of the permissions the same way, and provided update path.
#7
I think for now I'll stick with abbreviation like code user pifr.module, pifr_server.module. At somepoint I'm thinking about renaming.
#8
Copy-paste fail, pifr_update_6204 in pifr_server.install should be pifr_server_update_6204().
#9
Committed.
#10
Automatically closed -- issue fixed for 2 weeks with no activity.