This issue will try to remove most unnecessary notions of the world "Please" - following the interface text writing standards we set in http://drupal.org/node/604342 . The world "Please" sets an unfriendly type of language, where its intention is to make "commands" more friendly it usually sets the wrong tone - implying a user HAS to do something.

CommentFileSizeAuthor
#12 please-out-interface-679890-10.patch64.86 KBagentrickard
#10 please-out-interface-679890-10.patch64.88 KBaspilicious
#8 removing.more_.please.patch67 KBBojhan
#6 removing.please.patch2.28 KBBojhan
#3 removing.please.patch1.96 KBchx
#1 removing.please.patch2.28 KBBojhan

Comments

Bojhan’s picture

Bojhan commented
Status: Active » Needs review
StatusFileSize
new removing.please.patch2.28 KB

First patch, to see whether I am not doing anything wrong.

Status: Needs review » Needs work

The last submitted patch, removing.please.patch, failed testing.

chx’s picture

chx commented
Status: Needs work » Needs review
StatusFileSize
new removing.please.patch1.96 KB
dries’s picture

dries commented
Status: Needs review » Fixed

Committed! Thanks.

Bojhan’s picture

Bojhan commented
Status: Fixed » Active

You where a bit fast Dries, hehe :D Atleast 20 other mentions, but working on a patch

Bojhan’s picture

Bojhan commented
StatusFileSize
new removing.please.patch2.28 KB

There we go, decided not to remove a couple - because I wasn't sure about those, their context seems more important.

aspilicious’s picture

aspilicious commented
Status: Needs review » Active

Looks like the same patch...

Bojhan’s picture

Bojhan commented
Status: Active » Needs review
StatusFileSize
new removing.more_.please.patch67 KB

There we go a new one, the right one - had some problems getting cvs diff

Status: Active » Needs work

The last submitted patch, removing.more_.please.patch, failed testing.

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review
StatusFileSize
new please-out-interface-679890-10.patch64.88 KB

Try this test bot!

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

The patch i uploaded was originally of Bohjan I just cut out the part that already had been commited.
I read through the entire patch...
Looks good for me, setting RTBC

And I think this has to get in soon because it's affecting a lot of pages. Else it will need a reroll.

Dries or Webchick: this is a follow up patch on the patch Dries commited to HEAD. (#3)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new please-out-interface-679890-10.patch64.86 KB

Revised patch catches two missed instances of "please". Also removes several comma splice errors.

For example:

+      throw new Exception(st('Failed to modify %settings, verify the file permissions.', array('%settings' => $settings_file)));

Should be:

+      throw new Exception(st('Failed to modify %settings. Verify the file permissions.', array('%settings' => $settings_file)));

These are two separate command statements and require either a period (used in the revised patch) or a semicolon.

Also edited a few mistakes with ", or" constructions in "either...or" usage.

E.g.

+      $output .= '<p>' . t('For more information, refer to the specific topics listed in the next section, or the <a href="@handbook">online Drupal handbooks</a>. You may also post at the <a href="@forum">Drupal forum</a>, or view the wide range of <a href="@support">other support options</a> available.', array('@help' => url('admin/help'), '@handbook' => 'http://drupal.org/handbooks', '@forum' => 'http://drupal.org/forum', '@support' => 'http://drupal.org/support')) . '</p>';

Should be:

+      $output .= '<p>' . t('For more information, refer to the specific topics listed in the next section or the <a href="@handbook">online Drupal handbooks</a>. You may also post at the <a href="@forum">Drupal forum</a> or view the wide range of <a href="@support">other support options</a> available.', array('@help' => url('admin/help'), '@handbook' => 'http://drupal.org/handbooks', '@forum' => 'http://drupal.org/forum', '@support' => 'http://drupal.org/support')) . '</p>';

The construction is "refer to A or B", not "refer to A, or B."

Bojhan’s picture

Bojhan commented

Just reviewed your changes (jeez this is a big patch), those are better constructions. Good work!

yoroy’s picture

yoroy commented
Status: Needs review » Reviewed & tested by the community

Looked it over too and looking good.
Ready to be committed, please.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Drupal 7: Now with 700% less politeness! ;)

Committed to HEAD.

Bojhan’s picture

Bojhan commented
Component: base system » user interface text

Let me fix that, unnecessary politeness :)

Status: Fixed » Closed (fixed)
Issue tags: -Usability

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Usability

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.