Posted by Bojhan on January 9, 2010 at 4:00pm
8 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | user interface text |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | Usability |
Issue Summary
This issue will try to remove most unnecessary notions of the world "Please" - following the interface text writing standards we set in http://drupal.org/node/604342 . The world "Please" sets an unfriendly type of language, where its intention is to make "commands" more friendly it usually sets the wrong tone - implying a user HAS to do something.
Comments
#1
First patch, to see whether I am not doing anything wrong.
#2
The last submitted patch, removing.please.patch, failed testing.
#3
#4
Committed! Thanks.
#5
You where a bit fast Dries, hehe :D Atleast 20 other mentions, but working on a patch
#6
There we go, decided not to remove a couple - because I wasn't sure about those, their context seems more important.
#7
Looks like the same patch...
#8
There we go a new one, the right one - had some problems getting cvs diff
#9
The last submitted patch, removing.more_.please.patch, failed testing.
#10
Try this test bot!
#11
The patch i uploaded was originally of Bohjan I just cut out the part that already had been commited.
I read through the entire patch...
Looks good for me, setting RTBC
And I think this has to get in soon because it's affecting a lot of pages. Else it will need a reroll.
Dries or Webchick: this is a follow up patch on the patch Dries commited to HEAD. (#3)
#12
Revised patch catches two missed instances of "please". Also removes several comma splice errors.
For example:
+ throw new Exception(st('Failed to modify %settings, verify the file permissions.', array('%settings' => $settings_file)));Should be:
+ throw new Exception(st('Failed to modify %settings. Verify the file permissions.', array('%settings' => $settings_file)));These are two separate command statements and require either a period (used in the revised patch) or a semicolon.
Also edited a few mistakes with ", or" constructions in "either...or" usage.
E.g.
+ $output .= '<p>' . t('For more information, refer to the specific topics listed in the next section, or the <a href="@handbook">online Drupal handbooks</a>. You may also post at the <a href="@forum">Drupal forum</a>, or view the wide range of <a href="@support">other support options</a> available.', array('@help' => url('admin/help'), '@handbook' => 'http://drupal.org/handbooks', '@forum' => 'http://drupal.org/forum', '@support' => 'http://drupal.org/support')) . '</p>';Should be:
+ $output .= '<p>' . t('For more information, refer to the specific topics listed in the next section or the <a href="@handbook">online Drupal handbooks</a>. You may also post at the <a href="@forum">Drupal forum</a> or view the wide range of <a href="@support">other support options</a> available.', array('@help' => url('admin/help'), '@handbook' => 'http://drupal.org/handbooks', '@forum' => 'http://drupal.org/forum', '@support' => 'http://drupal.org/support')) . '</p>';The construction is "refer to A or B", not "refer to A, or B."
#13
Just reviewed your changes (jeez this is a big patch), those are better constructions. Good work!
#14
Looked it over too and looking good.
Ready to be committed, please.
#15
Drupal 7: Now with 700% less politeness! ;)
Committed to HEAD.
#16
Let me fix that, unnecessary politeness :)
#17
Automatically closed -- issue fixed for 2 weeks with no activity.