Posted by tstoeckler on January 9, 2010 at 5:33pm
Jump to:
| Project: | Time block |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
I am the maintainer of the Clock module, which I recently committed to Drupal CVS. It seems there is a great overlap between the two modules, although both have features the other one doesn't. I haven't looked into timeblock's code, but I think it should be the way to go to deprecate one of the modules in favor of a module which does both.
Comments
#1
I just checked out the Time block module. It didn't work for me (nothing showed up in the blocks), but I briefly looked at the code, to see what it does.
Following features are present in the Time block module, but not in the Clock module:
Following features are present in the Clock module, but not in the Time block module:
The feature to update the clock via JS is high on my list to include in Clock module anyways. The feature to use the user's local time zone I find kind of weird, because it is really just a copy of the clock displayed in the Operating system. Since I see the plans for Time block are to include the display of the date as well, I find the "Clock" namespace better that "Time block", but I guess that's just a matter of taste.
I'm eager to hear what you have to say! =)
#2
Just a note that version 6.x-1.1 of Clock module (http://drupal.org/node/697940) has the ability to update the clock continuously.
That leaves
as the only thing Time block module does, that Clock module doesn't. I would happily include that functionality in Clock module, if you would agree to merge the two in that case. (I won't include that functionality on my own, because I don't think it is very useful, as stated above.)
At the time the two module have around the same amount of users, with both usage statistics currently rising. I find it really sad to see people split among these two solutions to do more or less the same thing.
Please comment in any way. I would really like to make progress with this, even if the solution is not to immediately merge the two modules. Just stating your opinion (even if I might not like it) would be of great help. Thanks!
#3
This also appears to be duplicate of http://drupal.org/project/worldclock
#4
Well, yes and no.
It is a module which provides a block which gives the time, so yes.
But it has the ability to show multiple times in one block. I've been reluctant to introduce this feature in Clock module, because the fact that you can only have one instance of each block is really a block.module limitation. Together with MultiBlock module I guess the same thing could be achieved with Clock, but.
Also WorldClock does not depend on Date API but replicates part of it, especially all the timezone stuff.
#5
Sorry for the delayed response...
Just read this issue over -- here's my opinion:
Regardless of the outcome, I promise my feelings won't be hurt -- in fact I wish more maintainers (and/or site admins) would take the same initiative(s). And I'm just as guilty so don't get me wrong... Either way, @tstoeckler: nice work.
Anyway, yes. I agree. +1.
#6
Thanks for the response. Everything you said is very great to hear.
Here is my proposed plan:
1. I grant you CVS access for Clock (If you want, I'm just assuming yes)
2. I/You commit the feature to use the user's time zone.
3. I/You release a new version.
4. You put a text on your project page to lead people to Clock module. I'd also put something on Clock's project page to mention the merge.
5. One less duplicate module! Yay!
Regarding 2.: I'm pretty certain that it shouldn't be hard to do, but I'm off my working station for at least next week and moving to a new city after that, so it could about 2 weeks until that happens. I will check my tracker every 3-4 days though, so as soon as I get the heads-up from you, I'll grant you CVS access.
I'm very relieved to get such a positive response, coming into someone issue queue with the suggestion to shut down that module: Thanks again!
#7
Just a note, in case your interested.
Issue proposing to merge Clock and World clock modules (which I'm against): #717502: Merge with Worldclock
#8
I created #742020: Create option to use users Local time over in Clock's queue. Will probably post and commit a patch in the next week(s).
#9
#742020: Create option to use users Local time has been committed.
Now just waiting on your input to #6, for a new release.
#10
Just a note that in the meantime Clock 6.x-1.2 has been released, including the feature to use the user's Local time.
That makes Time block's features a true subset of Clock's features.
Now all that is needed, is to update the project page, to put up a link leading to Clock module, and tag the module "Obsoleted".
Also note that Clock already has a working Drupal 7 version.