Tokens not expanded when using custom_breadcrumbs (AKA hook_init might be to late to declare token hooks)

this would be critical
but, what caused it? conflict with another module?
how could I reproduce it?

the weight is not a critical issue regarding this module, it is set to 20 to be above token module (which has 10) just in case there is function theme_token_list already declared
note: that function doesn't exists in token module (AFAIK), but is proposed as a patch, so it might appear some day and brake if comment_subject executes before token

right now I can't see another strong reason for the weight other that form_alter assigning the #default_value to subjects, which might be broken if another module jumps in an try some tweaks, or... can't figure now another way

I can't reproduce it
what other modules are involved?
can you reproduce it on a fresh install and provide the steps to follow?

I'll download the latest version of custom_breadcrumbs and check this conflict

@#3 BTW, which version of custom_breadcrumbs? 6.x-1.5 or 6.x-2.0-beta2 ?

@#5 should be 6.x-2.x branch, which is the one with sub-modules

still can't reproduce it
- enabled custom_breadcrumbs 6.x-2.0-beta2 and no problem
- cleared the cache (to avoid cached forms) and no problem
- enabled "Custom Breadcrumbs for Paths", cleared the cache and no problem
- manually set weight=12 for custom_breadcrumbs at {system} table and no problem (details bellow)

reviewing the code I can't find custom_breadcrumbs setting its weight
but the custom_breadcrumbs_update_3 states:

// Ensure this module's weight is larger than other modules, like views, so custom breadcrumbs page callback is used.
function custom_breadcrumbs_update_3() {
  $ret[] = update_sql("UPDATE {system} SET weight = 12 WHERE name = 'custom_breadcrumbs'");
  return $ret;
}

that's why I manually set its weight to 12 for testing (it was 0 on fresh install) and though couldn't reproduce the error

this weight problem, should be found and properly fixed,
in the meantime, lets say comment_subject might happily use weight=11 (which is greater than token and less than custom_breadcrumbs), also, I consider custom_breadcrumbs using 12 is a narrow margin (maybe they should increase that weight), since token has 10

yet, I can't take any certain action, since I haven't been able to reproduce it

could you please provide every configuration you have related to custom_breadcrumbs or its sub-modules?
I need to reproduce this error to be able to figure out what would be the real fix

follow up issues:
#680934: module weight is no set on fresh install
#680936: increase module weight (12 is too low)

nevertheless I have to hit this error

I think this may be related to #543506: Problem with tokens when using a custom_bredcrumbs_paths. I'll have to look at the comment subject code to be sure. But if this is the case, once tokens issues a new release we should be able to fix this problem....

@MGN
thanks a lot for getting involved, that might be the reason why I haven't been able to reproduce this error
we actually have a token_replace($str, 'comment', $comment); which might be conflicting with custom_breadcrumbs due to token cache

@skizzo
I've never tried custom_breadcrumb_paths nor custom_breadcrumb_views
having your configuration would help me to hit this error

@MGN http://drupal.org/node/543506#comment-2460544

any two modules using token_replace_multiple on the same page request are likely to show this problem

just with token_replace_multiple?
this module uses token_replace, but not _multiple

@#14 the flushing cache problem affects token_replace as well, but I can't be sure that it is the cause, since I'm blind yet (haven't reproduce it)

good news!!
I've got it!

I reproduced this bug (wow, tough hunting)

thanks MGN for you insight
thanks skizzo for your patience

details & fix coming soon

@skizzo just to confirm
which tokens where you using and notice the missing replacements?

how to reproduce this bug (thanks for the clue MGN):
- fresh Drupal 6.15
- comment_subject 6.x-2.0-alpha2
- custom_breadcrumbs 6.x-2.0-beta2
- enable custom_breadcrumbs_paths as well
- token 6.x-1.12
- admin/settings/custom-breadcrumbs
--- check "Use wildcard pattern matching in paths" and save
- admin/build/custom_breadcrumbs/path/add
--- Specific Path: comment/reply/*
--- Titles: Original post
--- Paths: node/[comment-nid]
- create a story (node/1)
- create a comment replying to that story (node/1#comment-1)
- reply to the previous comment (comment/reply/1/1)
- on that path subject appears broken (tokens weren't replaced)

a quick test to check if it is due to custom_breadcrumbs (thanks for the clue skizzo):
- change the weight of custom_breadcrumbs_paths to something above 20 (the greatest the better to discard any other module with tokens being affected by this)
--- UPDATE `system` SET `weight` = '100' WHERE `filename` LIKE '%/custom_breadcrumbs_paths.module';

more technical details about why is this happening: #543506-4: Problem with tokens when using a custom_bredcrumbs_paths

the final solution:
- the cause is located
- a possible fix is to move hooks token_value & token_list inside comment_subject.module instead of a separated file (currently at comment_subject.token.inc)
- but I'll wait until getting in touch with other developers to check if this is actually a bug of comment_subject #681938: document proper practice for mymodule.token.inc files

a patch for custom_breadcrumbs is available at #627792-8: Custom Breadcrumb option causes Access Denied in OG Forums
it seems to solve this issue, but can't say if every other cb functionality remains working, its maintainer is asking for users testing that patch

this issue will remain postponed, since policy about *.token.inc files is now in D7 core, therefore there shouldn't be any requirement to include those hooks into the *.module file

no longer an issue of this module
details at #543506-4: Problem with tokens when using a custom_bredcrumbs_paths, and patch at #627792-8: Custom Breadcrumb option causes Access Denied in OG Forums was committed to custom_breadcrumbs HEAD and seems to fix this incompatibily problem (according to skizzo's feedback through mail)

this will get into next 6.x-2.x release

committed to head (proposed 6.x-2.0-beta1)

clearing the issue queue
(this was more kind of reminder)
this issue was troubleshooted directly with the user, plus custom_breadcrumbs got updated to avoid nasty hook_init, plus dev already avoids this