Designers and developers to those does not suffice id and classes in tegs, this patch solves this problem in the module poll.

CommentFileSizeAuthor
#7 poll_10.patch776 bytesStefan Nagtegaal
#3 poll_9.patch774 bytesB.X
poll.patch.txt895 bytesB.X

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Hm. Do we need the div? Could the id be placed in the ul itself?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs review

...and it's a patch.

B.X’s picture

B.X commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new poll_9.patch774 bytes

Ok...

killes@www.drop.org’s picture

killes@www.drop.org commented
Version: 4.7.2 » x.y.z

features go into development version.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

Sorry, not to pick nits, but the ID needs to be in quotes. *duck*

I'd also let one of the themer types look it over before marking it RTBC.

Stefan Nagtegaal’s picture

Stefan Nagtegaal commented
Status: Needs work » Reviewed & tested by the community

This is ready to go in, IMO... Setting status to reflect the change of state.

Stefan Nagtegaal’s picture

Stefan Nagtegaal commented
StatusFileSize
new poll_10.patch776 bytes

Damn, I forgot the updated patch...

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

An idea needs to be unique. If I have two polls on a page, this would result in invalid XHTML code?

LAsan’s picture

LAsan commented
Version: x.y.z » 7.x-dev

B.X: Any news about this?

features go into development version.

casey’s picture

casey commented

#8 Its a page: http://api.drupal.org/api/function/poll_page/7

But still I would use a class. Something like poll-list.

Also poll_page should use a renderable array for output. And instead of a hardcoded <ul>, an item_list.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: B.X » Unassigned
Status: Needs work » Fixed 
<div class="poll">

Already fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.