I need some guinea pigs testers to help me test the new Node Gallery Access module that is completely separate from the contribs.

There weren't many changes at all to the new module from the old contrib, save for the integration with Views. After enabling the module, you can display the node gallery access field, and you can also filter by it (i.e., show only public galleries).

Until it's fully separated from Node Gallery core, the installation isn't exactly straightforward. If you'd like to test, here's what you need to do:

  1. Make sure Node Gallery is installed and working.
  2. Make sure that Node Gallery Access (as included with Node Gallery) is disabled. No need to uninstall, just make sure it's disabled.
  3. Remove the entire Node Gallery Access folder under modules/node_gallery/contrib.
  4. Download and install the new Node Gallery Access module, grab the dev snapshot.
  5. Enable the module as normal.
  6. Report back here with your findings.

Once I get some reports of success, I'll remove the contrib version of Node Gallery Access so that installation will be straightforward.

Comments

dbeall’s picture

dbeall commented

looks good here http://www.davebeall.com/node-gallery5 ,oh yea, It works as expected..
Upgrade or change from contrib to node_gallery_access was error free, existing passwords work fine.
Adding it to buckeyelake.org since it works as expected...
* After things settle and move, I will work on the node_gallery handbook for changes.
* The node_gallery README will need a few changes and a README for node_gallery_access is in order.
* any feedback on this subject is always welcome...
Thank You Justintime

designwork’s picture

designwork commented

Hi justintime,

I tested all exept views integration and it works as desired.

thanks

Dirk

dbeall’s picture

dbeall commented

views is working, added the filter 'exposed' to my demo page.
The page has 1 public, 1 private and 4 password galleries.

If I set permission for anonymous user to 'access private galleries', all of the password galleries are open to view without a password as well..
I don't know if that's the way it's suppose to act.?

surprise content...
EDIT #1: should I be using the new issue que yet....lol
EDIT #2: Is the filter 'optional' check box suppose to supply a 4th choice.?
lol, more surprise content
EDIT #3: If I go to the gallery list at /galleries it shows all galleries from all the pages without using a 'view'..well, the password galleries are open. (it doesn't show the one private gallery(normal)..
...I am such a trouble maker...

justintime’s picture

justintime commented

If I set permission for anonymous user to 'access private galleries', all of the password galleries are open to view without a password as well..
I don't know if that's the way it's suppose to act.?

That's the intended functionality. Private means 'accessible only by the author'. That permission is intended for content admins to make sure users aren't storing questionable content in their private galleries. If everyone can access your private gallery, it's not really that private anymore ;-)

EDIT #1: should I be using the new issue que yet....lol

Probably - once I remove the contrib module, I'll remove the "Access contrib" dropdown.

EDIT #2: Is the filter 'optional' check box suppose to supply a 4th choice.?

Yep, that's a bug.

EDIT #3: If I go to the gallery list at /galleries it shows all galleries from all the pages without using a 'view'..well, the password galleries are open. (it doesn't show the one private gallery(normal)..

That's a feature, not a bug ;-) Node Gallery uses a non-view for it's /galleries page. Personally, I think this should be changed to be a view, and we can just require Views as a module dependency - but that's something we'll have to address later in a different issue.

I'll create a new issue for the bug you found.

justintime’s picture

justintime commented

@dbeall - I guess it's not really a bug after all: #681436: When using views, selecting "Optional" under "Expose" on Access Type doesn't add "N/A" to the options list

designwork’s picture

designwork commented

Hi justintime,

That's a feature, not a bug ;-) Node Gallery uses a non-view for it's /galleries page. Personally, I think this should be changed to be a view, and we can just require Views as a module dependency - but that's something we'll have to address later in a different issue.

I would suggest we make views optional. I suppose that if views is installed the /galleries page is a view, if not it stays a "normal" page. I know a lot of users wich don`t need views to be installed. Node_gallery depends allready on a few modules we schould not make more dependencies. We could make an option an the gallerie setting page to not show "private and password proteced galleries". I can write that easily. If you and kmoty agree.

Cheers

Dirk

justintime’s picture

justintime commented

Yeah, I suppose you're right. I just hate it because Views is always installed on any of my sites.

Regarding changing the /galleries page:

  • Private galleries use Drupal core's node access API, so they don't show up anyway.
  • While it may be easy to exclude password galleries, you're mingling Node Gallery Access features/code into Node Gallery. This is code that could get out of sync, and cause headaches down the road.

I think the best answer to a user wanting a /galleries page without password protected galleries listed on it is to write up documentation that shows them how to install Views and import a view that does that for them. I could even go so far as to import one by default via NGA's installation.

dddave’s picture

dddave commented

Tested and so far I think you can kill the access contrib.

Great work!

justintime’s picture

justintime commented
Status: Active » Fixed

Okay, we're go for launch.

I wrote up a handbook section under Node Gallery that addresses Add-On Modules.

I tagged a beta2 version of node_gallery_access.

I tagged a alpha12 version of node_gallery, which includes update.php hooks to ensure the old contrib version is removed.

Now, I just hold my breath. Thanks for the help everyone!

dddave’s picture

dddave commented

Went smooth on my install. Thx!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.