This patch contains two things. I can split them into separate patches if need be, but since they are pretty small I thought I'd throw it at you all at once.

1). Fixes the endless progress bar. This was caused by a settings variable no longer being set in javascript, it appears this was a change in ubercart. An example of my fix follows.

-    get_payment_details(Drupal.settings.ucURL.checkoutPaymentDetails + uc_free_order_next_method);
+    get_payment_details(Drupal.settings.basePath + 'cart/checkout/payment_details/' + uc_free_order_next_method);

2). Make the messaging configurable for the free order verbiage. I've added a settings for under admin/store/settings to allow you to change the title/description of the free order option on the checkout form. It's pretty straightforward stuff.

Patch is attached.

Comments

beeradb’s picture

bump. We're using this for a client site and I would love to get this resolved. Any chance you can take a look at the patch?

rich.yumul’s picture

Worked for me!

Thanks so much for posting it!

beeradb’s picture

bump again :) the site we're using this on is now live. Very interested in getting this synced back into head.

julient’s picture

Is it possible to get it as a patch file for testing?
I tried doing it from the diff file and I didn't get the proper code.

ayalon’s picture

Status: Needs review » Reviewed & tested by the community

Tested and fixed the error. I also like to option for renaming the payment method.

simon georges’s picture

Closing #661660: Endless Checkout Progress Bar (Yes, again) as duplicate of this one.

haysuess’s picture

This is still happening to me and none of the patches/solutions work for me! I have searched for 3 hours looking for a fix. This is really screwing me up!

Please help me here or on the new issue I started since this one closed: http://drupal.org/node/956568

haysuess’s picture

I'm also seeing an error in IE8 developer tools debugging saying on line 29 character 5 there is an error, "Object doesn't support this property or method". This is line 29...WTF?

Line 29:    var uc_free_order_next_method = $(':radio[name="panes[payment][payment_method]"]:enabled:first').val();
haysuess’s picture

I did more testing and have discovered that the problem has to do with having UC Free Order Payment and the Fusion: Acquia Prosper theme enabled together.

I downloaded the administration theme module and set cart/* to use garland as it's theme. I then went to checkout in IE8, and it happily loaded Garland as the theme, and walla, the progress bar worked fine.

Now I am stuck and don't know where to look to figure out where the conflict is. Anyone have any ideas?

haysuess’s picture

Even more! When I disabled Fusion as the theme, it also disabled the Cufon font replacement module. I left Fusion enabled and just disabled the Cufon module and everything works! I don't know what it was about Cufon that did it, but I'm pissed at it so will not be using it, at least until a new version comes out.

Whew!

Offlein’s picture

I had this issue as well. Disabling Cufon was the solution, annoyingly.

mcarbone’s picture

StatusFileSize
new907 bytes

Re: comment #8. Looks like the jQuery there causes problems on IE: http://api.jquery.com/radio-selector/#comment-4703

Attached patch works on beta4.

westwesterson’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new4.59 KB

Here is a summary patch.
It takes the messaging options from comment 1 and the input patch from comment 12.

Here are two changes since those patches:

  1. manage uc_free_order settings all from the payment settings page.
  2. gives the option to disable the 'discount' debugging options (disabled by default)

Note: you still need debugging permission in order to see the debugging options, but you can globally turn debugging off from the admin interface now.

If there is interest I might be able to break this out into smaller patches, but it appears no one is maintaining this module anyway... so...

xine’s picture

Re: comment #13
For the form field in line 91 in uc_free_order.module

$form['uc_free_orders_debug']['uc_free_orders_debug_on'] = array(
	      '#type' => 'checkbox',
	      '#default_value' => variable_get('uc_free_order_debug', FALSE),
	      '#title' => t('Enable Free Offer Debugging (not recommended for production sites)'),
	      '#description' => t('Turns on debugging on the checkout page.'),    
	    );

you should change that to :

$form['uc_free_orders_debug']['uc_free_order_debug'] = array(
	      '#type' => 'checkbox',
	      '#default_value' => variable_get('uc_free_order_debug', FALSE),
	      '#title' => t('Enable Free Offer Debugging (not recommended for production sites)'),
	      '#description' => t('Turns on debugging on the checkout page.'),    
	    );

to be able to save the debug variable

westwesterson’s picture

StatusFileSize
new4.96 KB

Updated patch with the adjustment in #14.
This patch now properly uninstalls variables that the patch creates.