Even though the underlining components seem to function, the bottom line is the code isn't highlighted and that qualify as critical. I'm confused about the Component. I'd be happy to provide more details but I really don't know what would be useful for troubleshooting at this point.

I've installed the code highlighter GeSHi but it doesn't seem to functioning properly even though the HTML have added tags for it that you can see at http://dynv.qc.to/content/useful-codes. The GeSHi Filter settings ( /admin/settings/geshifilter ) Styling, layout and CSS option CSS mode for syntax highlighting was set to Use CSS classes and an automatically managed external CSS style sheet.

This is most likely due to missing style but they're included in the header as this : &lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;<a href="view-source:http://dynv.qc.to/sites/default/files/geshifilter/geshifilter-languages-714a9c1a.css?v">/sites/default/files/geshifilter/geshifilter-languages-714a9c1a.css?v</a>&quot; /&gt; &lt;link type=&quot;text/css&quot; rel=&quot;stylesheet&quot; media=&quot;all&quot; href=&quot;<a href="view-source:http://dynv.qc.to/sites/default/modules/geshifilter/geshifilter.css?v">/sites/default/modules/geshifilter/geshifilter.css?v</a>&quot; /&gt;

What could cause this ?
Thanks

CommentFileSizeAuthor
#9 geshifilter-settings.png88.04 KBdynv
dynv.qc_.to-useful codes-missing_GeSHi_highlight.png35.84 KBdynv

Comments

dynv’s picture

dynv commented

Oops ! The site doesn't take well entities, here's what the header included : <link type="text/css" rel="stylesheet" media="all" href="/sites/default/files/geshifilter/geshifilter-languages-714a9c1a.css?v" /> <link type="text/css" rel="stylesheet" media="all" href="/sites/default/modules/geshifilter/geshifilter.css?v" />

soxofaan’s picture

soxofaan commented
Status: Active » Fixed

I guess the version of the GeSHi library you are using is 1.0.8 or later. In 1.0.8, there was a change in the CSS selectors that broke the highlighting of inline code fragments.
This was fixed (in a backward compatible way) in http://drupal.org/cvs?commit=252012
if you upgrade to 6.x-2.x-dev, it should work. If you don't want to use a dev snapshot, you could also use version 1.0.7 of GeSHi library for example.

(note to self: I should release a 6.x-1.3 version of GeSHi filter)

dynv’s picture

dynv commented
Status: Fixed » Active

Where do I get version 6.x-2.x-dev ? Thanks

Instead of a note, you can set yourself a task. ;)

soxofaan’s picture

soxofaan commented
Priority: Critical » Normal
Status: Active » Fixed

I mean 6.x-1.x-dev (which is at http://drupal.org/node/96348)

PS: #682234: Time for a 6.x-1.3 release ;)

dynv’s picture

dynv commented

In 6.x-1.x-dev geshifilter.install, everything below geshifilter_update_1() (geshifilter_update_6001(), geshifilter_update_6002() and their helper functions) is missing from 6.x-1.2, is that an upgrade from it (6.x-1.2) though ?

Thanks

Hmm ! How come all the issue settings are as I've last used them instead of being as they are ATM ? Anyway the bug still render 6.x-1.2 useless so it's critical unless I'm mistaken.

soxofaan’s picture

soxofaan commented
Title: HTML properly tagged for highlight and external link in header & available » No highlighting of inline code with GeSHi library 1.0.8 or later

In 6.x-1.x-dev geshifilter.install, everything below geshifilter_update_1() (geshifilter_update_6001(), geshifilter_update_6002() and their helper functions) is missing from 6.x-1.2, is that an upgrade from it (6.x-1.2) though ?

Those update functions were indeed added after 6.x-1.2, they implement the upgrade path for features that were added after 6.x-1.2.

I don't consider this a serious critical bug, as it only affects inline code snippets and there is a simple workaround (use a GeSHi library before 1.0.8). So the module is not useless. But I understand others could consider it critical. But as it is fixed now, there is not much point anymore in discussing if it's critical or normal.

Also, the problem is already fixed in CVS (and the fix is available through the development snapshot), so this issue is flagged as such, which is normal practice in the drupal.org bug tracker.

I hope this clarifies things.

dynv’s picture

dynv commented

Ah ! Thank you kindly for the explanation, I though you were mentioning this module version 1.0.8, as in 6.x-1.0.8, so I understand the simple workaround being it's the GeSHi library version 1.0.8.

So my site had GeSHi Filter 6.x-1.2 with the (suggested version 1.0.x) GeSHi library version 1.0.8.6 then, as you suggested in this issue, replaced geshifilter with 6.x-1.x-dev (keeping the same GeSHi library), the update affected no row, but there's still no highlighting as you may see in my page useful codes ; am I bound to replace the GeSHi library ?

soxofaan’s picture

soxofaan commented

it appears that the CSS file "geshifilter-languages.css" is not included in the markup, what CSS mode (on the GeSHi filter admin page) are you using?

The markup for highlighting itself looks ok now.

dynv’s picture

dynv commented
StatusFileSize
new geshifilter-settings.png88.04 KB

The GeSHi Filter settings ( /admin/settings/geshifilter ) Styling, layout and CSS option CSS mode for syntax highlighting was set to Use CSS classes and an automatically managed external CSS style sheet.

Original Post

I thought that was sufficient but I attached the full settings (as my laptop height is small, it was laborious ! I'd sure like to have a program that print to an image file ...) to this comment, I hope that will be sufficient.

soxofaan’s picture

soxofaan commented
Status: Fixed » Active

There should be a CSS file at http://dynv.qc.to/sites/default/files/geshifilter-languages.css, but I get page not found.

Try flushing the "GeSHi language definition cache", there is a button for that in the collapsed fieldset titled "GeSHi library version 1.8.0.6 detected". This should refresh the geshifilter-languages.css file.

Also: you didn't switch to the private download method on the file system settings (admin/settings/file-system), did you?
Note that the option "Use CSS classes and an automatically managed external CSS style sheet" can only work with the public download method.

dynv’s picture

dynv commented

Try flushing the "GeSHi language definition cache", there is a button for that in the collapsed fieldset titled "GeSHi library version 1.8.0.6 detected". This should refresh the geshifilter-languages.css file.

Yes ! It now function. Many thanks. :)

Also: you didn't switch to the private download method on the file system settings (admin/settings/file-system), did you?
Note that the option "Use CSS classes and an automatically managed external CSS style sheet" can only work with the public download method.

Indeed it was public. ;)

dynv’s picture

dynv commented
Status: Active » Fixed

Forgot to change the Status (actually didn't notice it was switched to active). I wish there was a code you could add at the beginning of edits to change the issue settings, perhaps like !settings status fixed. :\

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.