I've just installed Better Formats module and got this error in admin/settings/filters/defaults:

Notice: Undefined index: administer blocks in sites\all\modules\better_formats\better_formats_defaults.admin.inc on line 195

I guess there should be something like:

if ($reset || empty($roles[$perm])) {

instead of

if ($reset || !$roles[$perm]) {

Sorry for not providing a correct patch file, but the change is very small.

Comments

wwalc’s picture

Status: Patch (to be ported) » Needs review

Sorry... wrong status ;)

dragonwize’s picture

Status: Needs review » Fixed

Thanks. Committed with just a change from empty() to !isset() as empty() will fall through with an empty array which is valid.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.