Creating new galleries causes deleting directories

Hallo Reiner,
ich hatte deine Meldung schon heute früh gelesen und suche schon nach der Ursache.
Ich kann den Bug nicht reproduzieren. Kannst Du mir dabei helfen den zu erzeugen?

Ich habe in pruebas.puntolatinoclub.de eine Test Installation für Fälle wie dieses.
Benutzername: Natzrut
Passwort Tester_19 - ändern

Bitte informiere mich danach, damit ich Dir die Administrator Rechte zuweise.

bis dann
Juan Carlos

Promted text
You use the scheduler? For placing of news? At me a similar problem: #667732: The loaded photos leave

Original text
Случайно планировщиком не пользуетесь? Для размещения новостей? У меня похожая проблема: #667732: The loaded photos leave

Promted text
Small addition on #667732: The loaded photos leave. The scheduler can keep any document, unessentially gallery. And at preservation gallery files leave.

Original text
Небольшое дополнение для #667732: The loaded photos leave. Планировщик может сохранять любой документ, необязательно галерею. И при сохранении удаляются файлы галереи.

Hello Natzrut,

http://drupal.org/node/715664
It is not exactly the same issue but maybe have relation to the above link.

There is a patch to solve the issue , images desapear by revert revisions.

I change the status to fixed.

In case some body find it is not fixed the issue should change the status to active again.

Regards
Juan Carlos

Is this issue fixed with the 1.9 recently released ? This is a highly critical bug which prevents me from putting a website to production. I'm not able to give a step-by-step procedure to reproduce it, but I regularly lose all galleries on my test site (1.9-rc2). Thanks in advance.

Hello Haarht,

I never got this issue in my installations and never have reached to reproduce it but I have some changes implemented to prevent it.

I have added some restrictions in the hook_delete to avoid the "not wanted deletion" of gallery folders because only from this hook can be reached, the deleting files and folders function.

  //
  // this condition checks if by NODE EDIT the buttoms "Delete" and after this the Confirm Deletion was clicked.
  // 
  if ($_POST['form_id'] == 'node_delete_confirm' && $_POST['confirm'] == 1) {
    $delete = TRUE;
  }
  //
  // this condition checks if by ADMINISTER CONTENT nodes was checked, the bulk operation "Delete" was selected and after this the Confirm Deletion was clicked.
  // 
  elseif ($_POST['form_id'] == 'node_admin_content' && $_POST['operation'] == 'delete' && $_POST['confirm'] == 1) {
    $delete = TRUE;
  }
  else {
    $delete = FALSE;
  }

  if ($delete && !empty($node->ref)) {

    if (user_access('delete own gallery_assist content', $user) ||
        user_access('delete any gallery_assist content', $user) ||
        user_access('delete own gallery_assist_'. $node->type .' content', $user) ||
        user_access('delete any gallery_assist_'. $node->type .' content', $user)) {

I think and hope the added changes avoid realy a "not wanted" deletion of gallery folders/files.

Regards
Juan Carlos

PS
I recomende to update to the 1.9 version.

this is very similar problem to:
http://drupal.org/node/755130

Every time I update a node with Gallery enabled ALL gallery assit folders gets deleted :(

Hopefully implemented work around will fix it.

Yes almalino,

I know and I not understand why in some installations exist this problem. For example your. I am interest to investigate what is the cause but as before mentioned I can't reproduce the issue.

Can you test the 1.9 version and give me feedback???

Thanks in advance and regards
Juan Carlos

Hi Juan,

thank you for great work! :)

I do have 6.x-1.9-rc2 in my installation and it deleted directories. Do you propose to try latest development version?

Another solution could be if I send to you a complete Drupal Directory ZIP file and DB archive so that you will be able to instal my Drupal installation on your computer and try to reproduce the issue. What you think?

Very good Idea almalino,

if this allow me to reproduce the issue, this would be the best to fix this unpleasant issue.

send me the all necessary data.

I sent to you a privat mesage so you have my adress

Regards

Juan, all data has been sent to your e-mail.

Hi ! I've been extensively testing the latest stable release and as far as I can tell, the deletion of directories never occurred since the update. Thanks !

thanks Haarht,
thanks almalino,