4.7 port: properly implement all items on settings page to accept updates

I have tryed to update the settings page according to the new forms api: the page appears now, but some more testing needed:

function dba_settings() {
    if ( !user_access('dba administer database') ) {
	return message_access();
	}
  // Backups
  //$group = form_textfield(t('Default backup filename'), 'dba_default_filename', variable_get('dba_default_filename', 'backup.sql'), 45, 255, t('Default filename to use when backing up multiple tables.  If backing up only one table, the filename will default to the name of the table.  You will have an opportunity to modify this filename when you actually perform the backup.'));
  //$output = form_group(t('Database backup'), $group);
    $form['backup_options'] = array(
	'#type' => 'fieldset',
	'#title' => t('Database Backup'),
	'#collapsible' => TRUE,
	'#collapsed' => FALSE
	);
    $form['backup_options']['dba_default_filename'] = array(
	'#type' => 'textfield',
	'#title' => t('Default backup filename'),
	'#description' => t('Default filename to use when backing up multiple tables.  If backing up only one table, the filename will default to the name of the table.  You will have an opportunity to modify this filename when you actually perform the backup.'),
	'#default_value' => variable_get('dba_default_filename', 'backup.sql'),
	'#size' => 30,
	'#maxlength' => 64
	);

  // MySQL
  //$group = form_radios(t('Default check type'), 'dba_default_check_type', variable_get('dba_default_check_type', 'MEDIUM'), array('QUICK' => t('Quick'), 'FAST' => t('Fast'), 'CHANGED' => t('Changed'), 'MEDIUM' => t('Medium'), 'EXTENDED' => t('Extended')), t('MySQL databases support many types of database integrity checks.  Select your preferred default type from the list above.  Medium is the MySQL recommended default type.'));
  //$group .= form_radios(t('Repair option'), 'dba_repair', variable_get('dba_repair', 0), array('0' => t('Automatic'), '1' => t('Always'), '2' => ('Never')), t('By default, the dba module will only display a repair button if a table has been determined to need a repair.  Alternatively, you can make the module always display a repair button, or never display a repair button.'));
  //$output .= _is_mysql() ? form_group(t('MySQL table check & repair'), $group) : '';
  if ( _is_mysql() ) {
    $form['mysql_options'] = array(
	'#type' => 'fieldset',
	'#title' => t('MySQL table check & repair'),
	'#collapsible' => TRUE,
	'#collapsed' => FALSE
	);
    $form['mysql_options']['dba_default_check_type'] = array (
	'#type' => 'radios',
	'#title' => t('Default check type'),
	'#description' => t('MySQL databases support many types of database integrity checks.  Select your preferred default type from the list above.  Medium is the MySQL recommended default type.'),
	'#default_value' => variable_get('dba_default_check_type', 'MEDIUM'),
	'#options' => array('QUICK' => t('Quick'), 'FAST' => t('Fast'), 'CHANGED' => t('Changed'), 'MEDIUM' => t('Medium'), 'EXTENDED' => t('Extended'))
	);
    $form['mysql_options']['dba_repair'] = array (
	'#type' => 'radios',
	'#title' => t('Repair option'),
	'#description' => t('By default, the dba module will only display a repair button if a table has been determined to need a repair.  Alternatively, you can make the module always display a repair button, or never display a repair button.'),
	'#default_value' => variable_get('dba_repair', 0),
	'#options' => array('0' => t('Automatic'), '1' => t('Always'), '2' => ('Never'))
	);
    }

  return $form;
}

The dba settings page works in current cvs version too. No need to review this brute force conversion to Foms API..

Sorry, the status must be changed too.

Here's a version of the information as a patch.

Also, the code in comment #1 was missing options related to path, zip, email, and exclusion so I added those back.

Also, when I use this in my xampp installation I get these errors on settings->save, but the page is still saved:

Warning: unlink(C:\xampplite\tmp\dba2AD.tmp) [function.unlink]: Permission denied in C:\workspace\drupal\includes\file.inc on line 467

Warning: Cannot modify header information - headers already sent by (output started at C:\workspace\drupal\includes\file.inc:467) in C:\workspace\drupal\includes\common.inc on line 266

I had two problems with this version:

1. the checkboxes at admin/database don't show up (I assume they should, but have never really seen them)
2. I tried outputting a bz backup, a regular backup, and I tried emailing the backup to me, but it never got produced. I'll wait and see if it just needs a few more cron runs to be sure.

Thanks for picking this back up, dww.

The settings page appears to be fully functional with this patch. An automatic backup was created when I ran cron, however it was not mailed to me. Thus there appears to be a bug, but it is outside the scope of this patch and unrelated to the settings page.

I'm currently only worried about functionality, not looking very closely at the code. I'd really just like to see a release of the dba module for 4.7 that works. Please merge.

FWIW: I finally did receive the backup via email, it just took longer than I expected. My email client didn't recognize the mime encoded attachment, but again that's unrelated to your patch.