Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
overlay.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Jan 2010 at 22:10 UTC
Updated:
3 Jan 2014 at 01:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
yoroy commentedCurrently:

Desired:

Comment #2
jacineThis is not the only problem by far with ui.theme.css.
ui.theme.css is the jQuery Smoothness theme. It is not a reasonable default. Any site/theme that uses jQuery UI will have these styles imposed on it.
The patch I posted here fixes this problem for Seven, but we are running out of time on it: #614494: Give Seven a nice looking default jQuery UI theme. Demo here: http://bit.ly/7ftjcX
As far as other themes are concerned, the file will most likely need to be overwritten by the themer. There is an issue related to this here #583400: jQuery UI libraries are loading too much CSS that needs to be reverted / Allow jQuery UI themes to be swappable. I've started on a stripped down version for themers to start with. It's shown here: http://bit.ly/5pyd25
Comment #3
David_Rothstein commented@yoroy, it looks like your screenshots were made with the Seven theme underneath the overlay as well (on the Content Types page, right?) If you had made them with the main site theme underneath (e.g., Garland) you'd get a different result.
What's going on here is explained in more detail at #700832: Parts of the overlay inherit CSS from the underlying site theme, leading to a font mismatch in the overlay page title - in the general case, the overlay header and tabs are actually not even using the same theme as the rest of the overlay!!! (They are actually using the main site theme, and the jQuery UI stuff apparently was trying to paper it over a bit - but not really that well.)
So although #614494: Give Seven a nice looking default jQuery UI theme is in theory the right idea, that patch by itself doesn't fix this particular problem. We'd need to find a way to make the default jQuery UI theme for Seven be applied to all of the overlay, including the parts that aren't even using Seven - or else, rip this apart entirely. Ugh :(
Comment #4
aspilicious commentedVerdana is gone, Helvitica it is...
Still a problem?
Comment #5
David_Rothstein commentedAgain, this isn't an issue with the specific font - the problem is that the wrong theme is being used entirely. All you have to do is change the main site theme to something unusual and you can make these fonts bleed through from "underneath", into the overlay title and tabs. Seven can't fix it if Seven isn't even controlling it.
For more details, see here - I think this is the underlying cause:
#782656: The overlay title and tabs should be inside the child window, not the parent window
Comment #6
aspilicious commentedFixed by #668640: Overlay shouldn't be based on jQuery UI Dialog.
Change themes and fontsize stays the same :)
Comment #8
yoroy commentedStill defines Verdana:

Comment #9
yoroy commentedLets just remove that line
Comment #10
aspilicious commentedPlayed with this some more. You're right! Nice catch!
Love to RTBC this.
Comment #11
casey commentedStill applies.
Comment #12
ksenzeeStill applies and makes perfect sense.
Comment #13
jacineHow the heck did that get there? :P
Yes, please go away Verdana. RTBC +1.
Comment #14
dries commentedCommitted to CVS HEAD. Thanks.