Hi,

Say order total before discount is 20€.
After applying a 20€ discount that shall bring order total to zero (i.e. free order), user still have to enter credit card info for a 0€ payment.

Module installed :

  • uc_discounts_alt
  • uc_free_order
  • test payment gateway

Thanks

Laurent

Comments

agence web coheractio’s picture

agence web coheractio commented

Any ideas ?
Thanks

aelling’s picture

aelling commented

I am also looking for a solution to this.

julient’s picture

julient commented

same setup, same problem

agence web coheractio’s picture

agence web coheractio commented
Status: Active » Needs review

Found the problem :
uc_free_order us triggered when #edit-panes-payment-current-total on the payment panel is equal to zero .This id corresponds a hidden field that holds the total amount of the order.
However this field is calculated in a way that doesn't support all cases. For example, if you have VAT set up (uc_vat), the value of this field is wrong hence doesn't trigger uc_free_order when needed.

To fix this, I have changed "current total" to equal to the vat value. Hence if order subtotal is zero, VAT is zero and "current total" is also zero. Obviously, the "current total" is no longer the actual order total...

My quick fix is the following in ubercart/payment/uc_payment/uc_payment.js

function render_line_items() {
....
  var cur_total = 0;
  $.each(li_titles,
    function(a, b) {
      // Tally up the current order total for storage in a hidden item.
      if (li_titles[a] != '' && li_summed[a] == 1) {
        // Bug fix : Use value tax_2 (VAT) to fill cur_total
        //cur_total += li_values[a]; // Initial code
        if(a == 'tax_2') {
          cur_total = li_values[a]; // Fixed code
        }
      }
    }
  );
...

You will have to change tax_2 to match the id of your tax.

Of course a nicer fix would be better

In the meantime, hope this helps

Laurent

rkeppner’s picture

rkeppner commented

I was running into the same issue, but with the standard uc_taxes module. Taxes are only added for the merchant's home state, but if a customer had an order total of $0 (through a discount) and lived in the taxed state, they got the dreaded "We cannot process your order without payment" error message.

I finally came up with a simple workaround. I edited the conditions for sales tax in conditional actions. Where I originally checked that the order balance was greater than $0 and the billing state was the same as the merchant, I added one more condition: that the payment method was NOT Free order. That took care of the problem.

I'm documenting this here in the hopes of helping someone else before they spend another 3 hours trying to figure this out.

rbosscher’s picture

rbosscher commented

this is what i had to do to make it work:


function render_line_items() {
  // Set the timestamp for this update.
  var this_update = new Date();

  // Set the global timestamp for the update.
  line_update = this_update.getTime();

  // Put all the existing line item data into a single array.
  var cur_total = 0;
  $.each(li_titles,
    function(a, b) {
      // Tally up the current order total for storage in a hidden item.
    //   if (li_titles[a] != '' && li_summed[a] == 1) {
        cur_total = cur_total + li_values[a];
		
		//Added By me
		if(a == 'tax_4') {
          cur_total = cur_total - li_values[a]; // Fixed code
        }
      //}
    }
  );
jrust’s picture

jrust commented
Status: Needs review » Needs work

Needs to be done in a way that doesn't hard-code the tax line item id.

elc’s picture

elc commented

See http://drupal.org/product/uc_free_order

.. works for me.

mediacube.sk’s picture

mediacube.sk commented

I had the same problem on D7, I wanted to skip billing and payments at checkout if their price is 0. And after recoding uc_free_order to work with D7...it was still not the one. Then I realized it can be done by mymodule_form_alter hook like this: 

function mymodule_form_alter(&$form, $form_state, $form_id) {
  if($form_id == 'uc_cart_checkout_form') {
		$items = $form['panes']['cart']['cart_review_table']['#items'];
		$total = 0;
		foreach($items as $item){
			$total += $item->price * $item->qty;
		} 
		
		if($total <= 0){	
			unset($form['panes']['payment']);
			unset($form['panes']['billing']);
		}
    	}
}

So what I'm actually doing is deleting the panes dynamically based on the total price of the order. I have a subscription page, so there is never more than 1 product/subscription in a cart, but this solution works for any number of prods.

Hope it helps someone.