Checkboxes and/or Text field attributes cause 'Invalid argument supplied for foreach()' warnings

Getting a similar error when I am on the edit attributes page for the product. ...../node/19/edit/attributes

warning: Invalid argument supplied for foreach() in /nfs/c01/h09/mnt/32879/domains/new.prakprint.com/html/sites/all/modules/ubercart/uc_dependent_attributes/uc_dependent_attributes.module on line 187.

subscribing

I'm also receiving this error

# warning: Invalid argument supplied for foreach() in /var/www/html/sites/all/modules/ubercart/uc_dependent_attributes/uc_dependent_attributes.module on line 186.
# warning: Invalid argument supplied for foreach() in /var/www/html/sites/all/modules/ubercart/uc_dependent_attributes/uc_dependent_attributes.module on line 186.
# warning: Invalid argument supplied for foreach() in /var/www/html/sites/all/modules/ubercart/uc_dependent_attributes/uc_dependent_attributes.module on line 186

I'm getting the same errors as both blasthaus and dmurray. I suspect it is because i had installed the UC Option Images module which i suspect is somehow not compatible with the uc dependent attributes module. But i'm not sure.... Any thoughts?

I disabled and uninstalled the Option Images module and the problem seemed to have gone away temporarily, but seems to have returned upon installing the devel module and looking at the dev render info for a given product.

Even stranger; if I try to go from any of the "UC Product tabs" to the added "Options" list, I get redirected to a different product.

I found a "workaround for it":
"REMOVE" your attributes from the product afflicted.
Add the attributes you want back.
Re-configure your attribute options, and save the product.
This will clean up the glitch.

It appears to be only triggered by leaving a "Default" option which you may have turned OFF after configuring your options list.

I'm having the same issue.

warning: Invalid argument supplied for foreach() in uc_dependent_attributes.module on line 186.

I've tried to remove and re-add (new word) the attributes. This did not work.
I've tried to completely replace them with a new set. This did not work.

Right now, I'm stumped and looking at a list of 720 "warning: Invalid argument supplied for foreach()..."

I'm not using Option Images or Devel.

I have the same error

warning: Invalid argument supplied for foreach() in /var/www/shop/sites/all/modules/ubercart/uc_dependent_attributes/uc_dependent_attributes.module on line 186.

In peering through the code, I can see where this problem is stated to occur.
It looks as if the author's function array_hierarchy can't tell when an array value contains an array or not.
Here's a potential patch for the issue ... I haven't had time to test it, but it should alleviate arrays blowing up in your site(s).

Since PHP4 is officially dead, I added typecasts to some of the author's built-in functions regarding arrays. Typecasting to an array will ensure that whatever value is sent to a "foreach" is valid to loop on. If the value isn't useful, it will simply turn into array( 'value' );
Additional comments are welcome.

OH crap! Winmerge ran the patch backwards. Don't use this one.

Try this one instead. Sorry about the confusion.

This patch doesn't work for me I have always:

* warning: Invalid argument supplied for foreach() in [...]/modules/uc_dependent_attributes/uc_dependent_attributes.module on line 142.
* warning: reset() [function.reset]: Passed variable is not an array or object in [...]/modules/uc_dependent_attributes/uc_dependent_attributes.module on line 153.
* warning: key() [function.key]: Passed variable is not an array or object in [...]/modules/uc_dependent_attributes/uc_dependent_attributes.module on line 154.

Any idea?

Well ... back to the drawing board.
I'll take another look at it this weekend, if I have time.

Subscribe, having the same problem. Hopefully you can get the solution soon!
Thanks a lot in advance for solving this!

greetings, Martijn

Subscribing

Subscribing

This issue persists, subscribing.

subscribing

Attaching patch that I used for a quick fix. Was receiving the same error as in comment #4; this error doesn't do any harm the code just seemed not to properly handle empty arrays.

These errors are due to remnant database records not being deleted when product attributes and options are not updated. I have attached a patch that properly hooks into the product update process and cleans up the database. To clean up any existing products, simply save the products 'options' page.

I tested the patches above, even my own (#19) and none work. The theories also seem inaccurate.

The code below generates the error, lines 47-66. The $possible array is never generated for attributes that are either checboxes or text fields; if the product doesn't have other attributes that are either select box or radio options, then the array is never built and the error messages are displayed.

  // Filter attribute/option conbinations on the product add_to_cart form if
  // submitted via ajaxSubmit
  if (strstr($form_id, 'uc_product_add_to_cart_form_') && !empty($_POST)) {
    // Only attempt to adjust attributes if they exist
    if (isset($form['attributes'])) {
      // Build a 2-dimensional array of possible attribute and option ids
      foreach (element_children($form['attributes']) as $aid) {
        // Only Select and Radio attributes effect adjustments
        if ($form['attributes'][$aid]['#type'] == 'select' || $form['attributes'][$aid]['#type'] == 'radios') {
          foreach($form['attributes'][$aid]['#options'] as $oid => $option) {
            // Ignore additional required option
            if (!empty($oid)) {
              $possible[$aid][$oid] = array();
            }
          }
        }
      }
  
      // Build a hierarchy array of all possible attribute option combinations
      $possible = array_hierarchy($possible);

The below code attempts to check if $possible is not set so that errors are not thrown. Replace your existing function with below (note this relates to 6.x-1.0).

/**
 * Implementation of hook_form_alter().
 */
function uc_dependent_attributes_form_alter(&$form, $form_state, $form_id) {
  // Add an enabled checkbox to the product adjustments form
  if ($form_id == 'uc_product_adjustments_form') {
    // Retrieve disabled combinations from the database
    $result = db_query("SELECT combination FROM {uc_dependent_attributes} WHERE nid = %d", $form['nid']['#value']);
    $combos = array();
    while ($combo = db_result($result)) {
      $combos[] = $combo;
    }

    // Update the table header
    $form['table']['head']['#value'] = '<th>Enabled</th>'. $form['table']['head']['#value'];

    // Loop through each form element adding an enabled checkbox
    foreach (element_children($form['table']['body']) as $key) {
      $form['table']['body'][$key]['enabled'] = array(
        '#type' => 'checkbox',
        '#default_value' => !in_array($form['table']['body'][$key]['combo_array']['#value'], $combos),
        '#prefix' => '<td>',
        '#suffix' => '</td>',
        '#weight' => -1,
      );
    }

    // Add an additional form submit handler
    $form['#submit'][] = 'uc_dependent_attributes_uc_product_adjustments_form_submit';
  }
  // Filter attribute/option conbinations on the product add_to_cart form if
  // submitted via ajaxSubmit
  if (strstr($form_id, 'uc_product_add_to_cart_form_') && !empty($_POST)) {
    // Only attempt to adjust attributes if they exist
    if (isset($form['attributes'])) {
      // Build a 2-dimensional array of possible attribute and option ids
      foreach (element_children($form['attributes']) as $aid) {
        // Only Select and Radio attributes effect adjustments
        if ($form['attributes'][$aid]['#type'] == 'select' || $form['attributes'][$aid]['#type'] == 'radios') {
          foreach($form['attributes'][$aid]['#options'] as $oid => $option) {
            // Ignore additional required option
            if (!empty($oid)) {
              $possible[$aid][$oid] = array();
            }
          }
        }
      }
      
      if(!is_array($possible)) {
        $possible = array();
      }
    
      // Build a hierarchy array of all possible attribute option combinations
      $possible = array_hierarchy($possible);

  
      $disabled = array();
      // Retrieve all disabled attribute option combinations
      $result = db_query("SELECT combination FROM {uc_dependent_attributes} WHERE nid = %d AND enabled = 0", $form['nid']['#value']);
      while ($data = db_result($result)) {
        $combo = array();
        $combo_ordered = array();
  
        // Build a 2-dimensional array of disabled attribute and option ids
        foreach (unserialize($data) as $key => $value) {
          $combo[$key][$value] = array();
        }
  
        // Reorder 2-dimensional array to match form
        foreach (element_children($form['attributes']) as $aid) {
          // Only Select and Radio attributes effect adjustments
          if ($form['attributes'][$aid]['#type'] == 'select' || $form['attributes'][$aid]['#type'] == 'radios') {
            $combo_ordered[$aid] = $combo[$aid];
          }
        }
  
        // Build an array hierarchy and merge with other combos
        $disabled = array_merge_recursive_preserve($disabled, array_hierarchy($combo_ordered));
      }
      
      if(!empty($possible)) {
        // Filter out all disabled combinations from the possible combinations
        $filtered = array_diff_assoc_recursive($possible, $disabled);
        
        // Update the form attributes
        _uc_dependent_attributes_filter($filtered, $_POST['attributes'], $form['#parameters'][2]->attributes);
      }
    }
  }
}