misc transaction module

discussed this with gordon. this will be more broadly named a "misc charge module", since it will allow admins to configure special charges and use custom descriptions in the invoice.

I intend to provide a weight calculation method. The way it works with tangible is that is responds to form_alter and adds the required field/fields into the product form.

That is VERY USEFUL. :-) Thanks! It gives me an idea of priority.

FYI, the plan for UPS type modules (using 3rd party api) is that they will be written as "partner" modules of shipcalc.

"... and what about catching payment('adjust') hook to calculate price adjustment ?"

Can you please explain the charge(s) that you need in detail? I don't fully understand what you want from what I've read.

I have put a new module, sql, and a supporting .inc in the CVS.
http://cvs.drupal.org/viewcvs/drupal/contributions/modules/ecommerce/con...

To review.
1) install and activate flexicharge.

2) goto Administer > Store > Settings > Flexicharge

3) You can add as many charges as you like, each with a different name etc.

NB. There is only one TYPE of charge provided by example.inc. I have more types of charges that I haven't submitted to cvs yet. My aim is to get example.inc working properly first.

4) Once you have set up your charges. You can add a product and proceed through the checkout. See how nothing happens? That is because I am too stupid to get checkoutapi to work properly.

If you would like to help a stupid coder in need. Please follow the above and then look at example_general_flexicharge_checkoutapi(). If you can make that thing push the charge name and amount to the checkout review page then I'll be very grateful.

.s

Same instructions as previous post, but it should all work now.

Oh, and the other modules in there need to replace what you already have (4.7)

Please hold out and I'll put some new code up soon. I am getting it reviewed to make sure this is what is appropriate for ecommerce.

(changing the status back to task as this is still a development task)

Fixed bugs at #13

The required changes to store.module are all in store_transaction_calc_gross:

1) For each misc, check if there is a callback to handle custom calculation. So rather than accept the default addition of $rate, modules can choose to interrogate the transaction and apply their own logic.

2) For each misc item, check for "already_added" and if so, don't add to the subtotal. This means that modules can specify an invoice item which is just a statement of an amount that was included in the original price.

function store_transaction_calc_gross(&$txn) {

  $total = 0;
  foreach ((array)$txn->items as $item) {
    $total+= product_has_quantity($item) ? $item->price * $item->qty : $item-> price;
  }
  foreach ((array)$txn->misc as $key => $misc) {
    if (function_exists($misc->callback)) {
      $f = $misc->callback;
      $amount = $f($txn, $misc, $total);
    }
    elseif ($misc->qty) {
      $amount = ($misc->price * $misc->qty);
    }
    else {
      $amount = $misc->price;
    }
    if(!$misc->already_added) {$total+= $amount;};
  }

  return $total;
}

The required changes to cart.module are all in cart_checkoutapi. Nothing different in calculating the items. Until we get to the misc transactions...

I've restructured the way the lines are built so that flexicharge can push out subtotals where it likes. I have to track the line # so that doubled-up subtotals can be repressed. There is also a little bit that reflects the way store_transaction_calc_gross works, but this duplication is already there.

      // Since we are going to be removing lines, keep a track of the current key.
      $line = 0;
      // To keep track of subtotal lines, attach some formapi friendly date.
      $st = array('#row_type' => 'ST');

      // Create a subtotal, if the Total comes immediately afterwards, then it will be repressed
      $form['totals'][$line++] = array('#title' => t('Subtotal'), '#value' => $txn->subtotal, 'info' => $st);

      $form['totals'] = array();
      if ($txn->misc) {
        foreach ($txn->misc as $misc) {

          if (!$misc->seen) {
            // Subtotal
            if ($misc->subtotal_before && ($form['totals'][$line-1]['info']['#row_type'] != $st['#row_type'])) {
              $form['totals'][$line++] = array('#title' => t('Subtotal'), '#value' => $txn->subtotal, 'info' => $st);
            }
          }

          // Do this just like store_transaction_calc_gross
          if (function_exists($misc->callback)) {
            $f = $misc->callback;
            $amount = $f($txn, $misc, $txn->subtotal);
          }
          elseif ($misc->qty) {
            $amount = ($misc->price * $misc->qty);
          }
          else {
            $amount = $misc->price;
          }
          if(!$misc->already_added) { $txn->subtotal+= $amount; }

          if (!$misc->seen) {
            // Misc Item
            $form['totals'][$line++] = array('#title' => t($misc->description), '#value' => $amount);
            // Subtotal
            if ($misc->subtotal_after) {
              $form['totals'][$line++] = array('#title' => t('Subtotal'), '#value' => $txn->subtotal, 'info' => $st);
            }
          }
        }
      }
      // Remove any subtotal occurring before the total.
      if ($form['totals'][$line-1]['info']['#row_type'] == $st['#row_type']) {
        unset($form['totals'][$line-1]);
      }

files and patches are all in CVS now.
http://cvs.drupal.org/viewcvs/drupal/contributions/modules/ecommerce/con...

I am very close to adding more charge types. Glad you like it so far.

Cross-link to groups where you can add your ideas:
http://groups.drupal.org/node/837

Hi Joshua L

Thanks for your ideas.
I advise against using this in production yet because it is basically at the proof-of-concept stage.

Review period is over.
Here is next step: http://drupal.org/node/83039