I just deleted a site and I see that the generic aliases symlinks are left hanging in the sites folder.

www.site.org -> site.org

...while site.org has been removed and does not exists in this folder anymore.

Comments

anarcat’s picture

anarcat commented
Assigned: Unassigned » anarcat

Taking a look at this.

anarcat’s picture

anarcat commented
Status: Active » Fixed

I can't reproduce this on our test server, running HEAD. Can you try again (I updated the prod server)?

anarcat’s picture

anarcat commented
Status: Fixed » Needs work

Actually, I *could* reproduce this. One needs to have redirection *disabled* for this to work however, check that out, after removing test.com and test3.com:

drwxr-xr-x  6 hostmaster hostmaster 4096 jan 18 18:22 .
drwxr-xr-x 10 hostmaster hostmaster 4096 sep 28 17:45 ..
lrwxrwxrwx  1 hostmaster hostmaster    8 jan 18 18:13 alias.test.com -> test.com
drwxr-xr-x  5 hostmaster hostmaster 4096 sep 25 13:30 all
drwxr-xr-x  2 hostmaster hostmaster 4096 sep 16 15:40 default
lrwxrwxrwx  1 hostmaster hostmaster    9 jan 18 18:15 www.test3.com -> test3.com
lrwxrwxrwx  1 hostmaster hostmaster    8 jan 18 18:13 www.test.com -> test.com

Definitely a problem here.

anarcat’s picture

anarcat commented
Status: Needs work » Fixed

Fixed in 93b0a57

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit dc08388 on debian, dev-dns, dev-envobject, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-simplerinstaller, dev-site_rename, dev-ssl, dev_716166_apache_conf, dev_dns, dev_server_verify, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by anarcat: 
    #683800 - fix removal of symlink on site removal

this was failing...
  • Commit 1ee65ab on debian, dev-dns, dev-envobject, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-nginx, dev-platform_management, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-simplerinstaller, dev-site_rename, dev-ssl, dev_716166_apache_conf, dev_dns, dev_server_verify, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by anarcat:
    #683800 - fix removal of symlink on site removal

this was failing...