There are a few aspects of the code in this module that don't adhere to drupal
coding standards (http://drupal.org/coding-standards).
Things like indenting with two spaces instead of tabs, using uppercase for constants
like TRUE, FALSE & NULL, closing array brackets being indented, using curly braces
with control statements even if they are only one line and comments being on the
line immediately before the next line of code.
It might seem petty but it is much easier if code adheres to these standards.
It is also important in this case because you intend the module to be used as an API,
so people will be reading and reusing your code to make modules that use the API.
Comments
Comment #1
freixas commentedI tried to stick to the Drupal coding standards (I could have sworn I used 2 spaces for indentation, but XEmacs optimizes and turns sets of 8 spaces into tabs), but I confess that I don't have them memorized and tend to work in about a dozen languages on as many different projects in any given month.
I don't have any problem with fixing the issues you mentioned, but they are not a priority. If you like, you can create a patch and I'll apply it. Thanks!
Comment #2
agileware commentedI'll wait to hear back about #709912: Module doesn't do anything when editing/deleting orders via orders admin area
first in case you are to commit that change but after that I'll do you a patch for this.
Otherwise if I do this one now they won't apply over each other.
Comment #3
freixas commentedComment #4
keithm commenteduc_product_keys-7.x-1.x passes Coder code review as of commit ab00de4f850df71e25a122d53c34c16aad972fe0.