Hi, thanks for this little great module.
However I had a little problem. Menu items can be enabled/disabled, but even if they are disabled they where showing. So I made a simple patch to expose this attribute which i then can use as a filter views.

CommentFileSizeAuthor
#8 expose_hidden_field-684270-8.patch828 bytesidflood
#2 menu_node_view-hidden-684270-2.patch1.02 KBidflood
menu_node_view-hidden.patch844 bytesidflood

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review

Makes sense.

idflood’s picture

idflood commented
StatusFileSize
new menu_node_view-hidden-684270-2.patch1.02 KB

Simple reroll of first patch. I tested it over the year on some production sites and I don't see anything to change to it.

Mołot’s picture

Mołot commented
Status: Needs review » Reviewed & tested by the community

Works like a charm for me.
One of the big official governemnt sites...

Tested by me, my co-workers and my team's captain. I think I may safely mark this as tested by community.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Awesome. Thanks.

capellic’s picture

capellic
he/him/his
Location Austin, Texas
commented

I have also tested this patch and it works. The only thing I would suggest would be to consider changing "Hidden" to "Enabled." I realize the field name is "hidden" but it's labeled "Enabled" on the menu listing admin pages. This is bound to cause confusion. Of course this may cause even more confusion because I'd naturally add a 1 for the value in the filter to show enabled values when that would achieve the exact opposite-- only showing the hidden menu items.

Unless the maintainer wants to make this small tweak, I think this is ready to be applied.

silurius’s picture

silurius commented

Would love to test a similar patch for 7.x-1.x-dev. Subscribing.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

I think this patch might apply directly to 7.

idflood’s picture

idflood commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new expose_hidden_field-684270-8.patch828 bytes

The patch applies to d7 but just in case here is a simple reroll. I'm not sure if the original patch was for the 6.x version of if this was a mistake.

technikh’s picture

technikh commented

#8 works great

silurius’s picture

silurius commented

Yep, works beautifully. Thanks!

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 7.x

   c7ec019..e19cb7b  7.x-1.x -> 7.x-1.x
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Patch (to be ported) » Fixed

Committed to 6.x

 3dcfce2..7f1286b  6.x-1.x -> 6.x-1.x

@idflood - This module is looking for a new maintainer if you are interested.

idflood’s picture

idflood commented

Thanks agentrickard. I have to admit that I don't use this module regularly. In fact it has been a long time since I have not used it so I don't think I'm a good candidate for being a maintainer.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

OK. Thanks for thinking about it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.