When viewing a node, if you don't have access to view revisions, _node_revision_access() should bail out early, instead that seems to be the last check. This results in a query on single node views for auth users which shouldn't be there.

http://api.drupal.org/api/function/_node_revision_access/7

CommentFileSizeAuthor
#6 node_revision_access.patch2.17 KBcatch
#4 node_revision_access.patch2.17 KBcatch
#2 node_revision_access.patch2.66 KBcatch
#1 node_revision_access.patch2.66 KBcatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
Title: _node_revision_access() issues unecessary query » _node_revision_access() issues unnecessary query
Status: Active » Needs review
StatusFileSize
new node_revision_access.patch2.66 KB

Here's a patch.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new node_revision_access.patch2.66 KB

Code style horror, no other changes.

Status: Needs review » Needs work

The last submitted patch, node_revision_access.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new node_revision_access.patch2.17 KB

Fix typo.

Status: Needs review » Needs work

The last submitted patch, node_revision_access.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new node_revision_access.patch2.17 KB

This one passes.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Nice catch. Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Performance

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Performance

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.