Closed (fixed)
Project:
Drupal core
Component:
taxonomy.module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
31 Mar 2004 at 23:33 UTC
Updated:
2 Feb 2005 at 17:15 UTC
Jump to comment: Most recent file
I wanted to add caching by a static variable to
taxonomy_get_vocabularies(). While I was doing this, I remembered a
discussion about putting the node types in their own table and extended
the patch to do this.
A problem is that all selects on the vocabulary table will no longer
contain the node types. Does anybody know of where this might cause
problems? taxonomy_get_vocabularies() will also not return the node type
if called without parameter. I solved the only problem I found that
was caused by this.
The patch is incomplete, it does not contain update information and
database schemes. It also isn't tested. I'd like to get some feedback on the implementation.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | taxo_4.diff | 11.64 KB | killes@www.drop.org |
| #4 | taxo_3.diff | 11.09 KB | killes@www.drop.org |
| #3 | taxo_2.diff | 11.11 KB | killes@www.drop.org |
| #2 | taxo_1.diff | 9.33 KB | killes@www.drop.org |
| taxo_0.diff | 4.7 KB | killes@www.drop.org |
Comments
Comment #1
killes@www.drop.org commentedDoesn't apply anymore.
Comment #2
killes@www.drop.org commentedI've updated the patch, but the upgrade path is still missing.
Related issues:
http://drupal.org/node/15690
http://drupal.org/node/6357
http://drupal.org/node/12542
Comment #3
killes@www.drop.org commentedRemoved static caching, addedupgrade path.
Comment #4
killes@www.drop.org commentedNew version. Removes taxonomy_get_vocab_by_name. Wasn't used.
Comment #5
tangent commentedAre you sure no modules use get_vocab_by_name? I know that the mailhandler module allows specifying a taxonomy by name instead of by id.
Comment #6
killes@www.drop.org commentedYes, I am sure. grep is my friend. To be honest: metatags module uses it, but that isn't really maintained.
mailhandler lets users add taxo _terms_ by name not vocabs.
Comment #7
tangent commentedThat's true about the terms versus vocalulary. My bad. I guess I'm still getting used to the whole taxonomy system.
Comment #8
killes@www.drop.org commentedOk, another patch. Upgrade path is tested (We apparently cannot have two updates on the same day). I also removed a bug that would not show you node types if you assigned vocabs to a node type and later disabled the module. You will no longer lose this assignment when editing the vocabulary.
Comment #9
dries commentedCommitted to HEAD.
Comment #10
(not verified) commented